From: Andy Whitcroft <apw@shadowen.org>
To: Mike Frysinger <vapier.adi@gmail.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: checkpatch.pl and no newline handling
Date: Tue, 13 Nov 2007 10:18:58 +0000 [thread overview]
Message-ID: <20071113101858.GD12003@shadowen.org> (raw)
In-Reply-To: <8bd0f97a0711121146w30b88cdcs8abf3f5b6bff2d14@mail.gmail.com>
On Mon, Nov 12, 2007 at 02:46:30PM -0500, Mike Frysinger wrote:
> the current checkpatch.pl does not reject new files that lack a
> newline, yet rejects patches that fix newlines in files ... quite the
> opposite of what we actually want
Nice. Just what the world needs. I wonder what the heck that format
means. Obviously the "corrupt" check is wrong as a "\ No newline" line
is valid not corrupt. Now when is "\ No newline" a good thing and when
a bad thing. It _looks_ like it is 'bound' to the line before, and if
so then its pretty simple.
Bad:
> +moo
> \ No newline at end of file
Good:
> -moo
> \ No newline at end of file
/me goes read the source for diff. Sigh.
Thanks for the report.
-apw
next prev parent reply other threads:[~2007-11-13 10:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-12 19:46 checkpatch.pl and no newline handling Mike Frysinger
2007-11-13 10:18 ` Andy Whitcroft [this message]
2007-11-13 10:55 ` Andy Whitcroft
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071113101858.GD12003@shadowen.org \
--to=apw@shadowen.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vapier.adi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.