From: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
To: David Miller <davem@davemloft.net>
Cc: akpm@linux-foundation.org, ananth@in.ibm.com,
linux-kernel@vger.kernel.org, hch@infradead.org,
randy.dunlap@oracle.com, anil.s.keshavamurthy@intel.com,
prasanna@in.ibm.com
Subject: Re: [PATCH] Move kprobes examples to samples/ (resend)
Date: Tue, 13 Nov 2007 07:53:26 -0500 [thread overview]
Message-ID: <20071113125326.GA16455@Krystal> (raw)
In-Reply-To: <20071113.040342.178304306.davem@davemloft.net>
* David Miller (davem@davemloft.net) wrote:
> From: Andrew Morton <akpm@linux-foundation.org>
> Date: Tue, 13 Nov 2007 04:00:45 -0800
>
> > On Sun, 21 Oct 2007 18:09:19 +0530 Ananth N Mavinakayanahalli <ananth@in.ibm.com> wrote:
> >
> > > Move kprobes examples from Documentation/kprobes.txt to under samples/.
> > > Patch originally by Randy Dunlap.
> > >
> > > In addition, I have
> > >
> > > o Updated the patch to apply on 2.6.23-mm1
> > > o Modified examples code to build on multiple architectures. Currently,
> > > the examples code works for x86_64, x86_32 and powerpc
> > > o Cleaned up unneeded #includes
> >
> > Could you please take a look at what's needed to get this working on sparc64?
> >
> > samples/kprobes/kretprobe_example.c: In function `ret_handler':
> > samples/kprobes/kretprobe_example.c:19: error: implicit declaration of function `regs_return_value'
>
> kretprobes support most likely, it's on my todo list to implement
> but it will take a while since I'm busy fixing networking bugs
> but I can stop doing that if you like.
>
> :-)
I wonder if compiling this example makes sense when
ARCH_SUPPORTS_KRETPROBES is not defined ? We could just use a
obj-$ARCH_SUPPORTS_KRETPROBES to compile the example conditionally.
Mathieu
--
Mathieu Desnoyers
Computer Engineering Ph.D. Student, Ecole Polytechnique de Montreal
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68
next prev parent reply other threads:[~2007-11-13 12:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-21 12:39 [PATCH] Move kprobes examples to samples/ (resend) Ananth N Mavinakayanahalli
2007-11-13 12:00 ` Andrew Morton
2007-11-13 12:03 ` David Miller
2007-11-13 12:53 ` Mathieu Desnoyers [this message]
2007-11-13 15:39 ` Ananth N Mavinakayanahalli
2007-11-13 15:47 ` [patch 1/2] Kprobes: Indicate kretprobe support in arch/<arch>/Kconfig Ananth N Mavinakayanahalli
2007-11-13 15:50 ` [patch 2/2] Kprobes: Build kretprobe samples only if arch supports kretprobes Ananth N Mavinakayanahalli
2007-12-08 0:35 ` [patch 1/2] Kprobes: Indicate kretprobe support in arch/<arch>/Kconfig Andrew Morton
2007-12-08 15:16 ` Mathieu Desnoyers
2007-11-13 20:15 ` [PATCH] Move kprobes examples to samples/ (resend) Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071113125326.GA16455@Krystal \
--to=mathieu.desnoyers@polymtl.ca \
--cc=akpm@linux-foundation.org \
--cc=ananth@in.ibm.com \
--cc=anil.s.keshavamurthy@intel.com \
--cc=davem@davemloft.net \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=prasanna@in.ibm.com \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.