Re: [PATCH 1/13] serverworks: cleanup ->set_dma_mode method

[Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>]

On Tuesday 13 November 2007, Sergei Shtylyov wrote:

[...]

> > Index: b/drivers/ide/pci/serverworks.c
> > ===================================================================
> > --- a/drivers/ide/pci/serverworks.c
> > +++ b/drivers/ide/pci/serverworks.c
> > @@ -164,25 +164,12 @@ static void svwks_set_dma_mode(ide_drive
> >  	ultra_timing	&= ~(0x0F << (4*unit));
> >  	ultra_enable	&= ~(0x01 << drive->dn);
> >  
> > -	switch(speed) {
> > -		case XFER_MW_DMA_2:
> > -		case XFER_MW_DMA_1:
> > -		case XFER_MW_DMA_0:
> > -			dma_timing |= dma_modes[speed - XFER_MW_DMA_0];
> > -			break;
> > -
> > -		case XFER_UDMA_5:
> > -		case XFER_UDMA_4:
> > -		case XFER_UDMA_3:
> > -		case XFER_UDMA_2:
> > -		case XFER_UDMA_1:
> > -		case XFER_UDMA_0:
> > -			dma_timing   |= dma_modes[2];
> 
>     Why it needs to change in the first place?

Indeed, there is a needless coupling of MWDMA/UDMA timings in serverworks.

Care to fix it?

Bart