From: Johannes Sixt <johannes.sixt@telecom.at>
To: git@vger.kernel.org
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 05/11] Use is_absolute_path() in sha1_file.c.
Date: Tue, 13 Nov 2007 22:43:05 +0100 [thread overview]
Message-ID: <200711132243.05877.johannes.sixt@telecom.at> (raw)
In-Reply-To: <Pine.LNX.4.64.0711132138360.4362@racer.site>
On Tuesday 13 November 2007 22:39, Johannes Schindelin wrote:
> Hi,
>
> On Tue, 13 Nov 2007, Johannes Sixt wrote:
> > diff --git a/sha1_file.c b/sha1_file.c
> > index f007874..560c0e0 100644
> > --- a/sha1_file.c
> > +++ b/sha1_file.c
> > @@ -86,7 +86,7 @@ int safe_create_leading_directories(char *path)
> > char *pos = path;
> > struct stat st;
> >
> > - if (*pos == '/')
> > + if (is_absolute_path(path))
> > pos++;
>
> Is this enough? On Windows, certain "absolute" paths would need "pos +=
> 3", no?
True, but this series is not yet about the MinGW port itself. It will be
changed eventually, but not at this time.
-- Hannes
next prev parent reply other threads:[~2007-11-13 21:43 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-13 20:04 [PATCH 0/11] Miscellaneous MinGW port fallout Johannes Sixt
2007-11-13 20:04 ` [PATCH 01/11] t5300-pack-object.sh: Split the big verify-pack test into smaller parts Johannes Sixt
2007-11-13 20:04 ` [PATCH 02/11] t7501-commit.sh: Not all seds understand option -i Johannes Sixt
2007-11-13 20:04 ` [PATCH 03/11] t5302-pack-index: Skip tests of 64-bit offsets if necessary Johannes Sixt
2007-11-13 20:04 ` [PATCH 04/11] Skip t3902-quoted.sh if the file system does not support funny names Johannes Sixt
2007-11-13 20:05 ` [PATCH 05/11] Use is_absolute_path() in sha1_file.c Johannes Sixt
2007-11-13 20:05 ` [PATCH 06/11] Move #include <sys/select.h> and <sys/ioctl.h> to git-compat-util.h Johannes Sixt
2007-11-13 20:05 ` [PATCH 07/11] builtin run_command: do not exit with -1 Johannes Sixt
2007-11-13 20:05 ` [PATCH 08/11] Close files opened by lock_file() before unlinking Johannes Sixt
2007-11-13 20:05 ` [PATCH 09/11] Allow a relative builtin template directory Johannes Sixt
2007-11-13 20:05 ` [PATCH 10/11] Introduce git_etc_gitconfig() that encapsulates access of ETC_GITCONFIG Johannes Sixt
2007-11-13 20:05 ` [PATCH 11/11] Allow ETC_GITCONFIG to be a relative path Johannes Sixt
2007-11-15 6:53 ` Steffen Prohaska
2007-11-15 18:31 ` Johannes Sixt
2007-11-15 20:10 ` Steffen Prohaska
2007-11-15 21:43 ` Johannes Sixt
2007-11-15 22:24 ` Steffen Prohaska
2007-11-13 21:22 ` [PATCH 10/11] Introduce git_etc_gitconfig() that encapsulates access of ETC_GITCONFIG Johannes Schindelin
2007-11-13 21:35 ` Johannes Sixt
2007-11-13 21:43 ` Johannes Schindelin
2007-11-13 21:05 ` [PATCH 08/11] Close files opened by lock_file() before unlinking Johannes Schindelin
2007-11-13 21:39 ` [PATCH 05/11] Use is_absolute_path() in sha1_file.c Johannes Schindelin
2007-11-13 21:43 ` Johannes Sixt [this message]
2007-11-13 21:48 ` Johannes Schindelin
2007-11-14 21:57 ` Robin Rosenberg
2007-11-13 20:10 ` [PATCH 0/11] Miscellaneous MinGW port fallout Johannes Sixt
2007-11-13 21:10 ` Junio C Hamano
2007-11-13 21:32 ` Johannes Sixt
2007-11-13 21:46 ` Johannes Schindelin
2007-11-13 21:54 ` Johannes Sixt
2007-11-13 22:22 ` Junio C Hamano
2007-11-14 11:02 ` Junio C Hamano
2007-11-14 14:50 ` Johannes Schindelin
2007-11-14 20:13 ` Junio C Hamano
2007-11-14 20:45 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200711132243.05877.johannes.sixt@telecom.at \
--to=johannes.sixt@telecom.at \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.