From: David Gibson <dwg@au1.ibm.com>
To: Valentine Barshak <vbarshak@ru.mvista.com>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 1/2] PowerPC: 4xx uic: add mask_ack callback
Date: Wed, 14 Nov 2007 11:57:34 +1100 [thread overview]
Message-ID: <20071114005734.GA19378@localhost.localdomain> (raw)
In-Reply-To: <20071113202521.GA26295@ru.mvista.com>
On Tue, Nov 13, 2007 at 11:25:21PM +0300, Valentine Barshak wrote:
> This adds uic_mask_ack_irq() callback to PowerPC 4xx uic code
> to avoid kernel crash. It is used for edge-triggered interrupts
> by handle_uic_irq().
Oops. Obviously never caught this obvious bug, because I've never
used an edge-triggered interrupt on the Ebony yet.
> Signed-off-by: Valentine Barshak <vbarshak@ru.mvista.com>
Acked-by: David Gibson <david@gibson.dropbear.id.au>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
next prev parent reply other threads:[~2007-11-14 0:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-13 20:15 [PATCH 0/2] PowerPC: 4xx uic updates Valentine Barshak
2007-11-13 20:25 ` [PATCH 1/2] PowerPC: 4xx uic: add mask_ack callback Valentine Barshak
2007-11-14 0:57 ` David Gibson [this message]
2007-11-13 20:27 ` [PATCH 2/2] PowerPC: make 4xx uic use generic edge and level irq handlers Valentine Barshak
2007-11-14 2:13 ` David Gibson
2007-11-14 3:43 ` Benjamin Herrenschmidt
2007-11-14 12:31 ` Valentine Barshak
2007-11-14 14:00 ` [PATCH 2/2] PowerPC: make 4xx uic use generic level irq handler Valentine Barshak
2007-11-14 2:05 ` [PATCH 0/2] PowerPC: 4xx uic updates Josh Boyer
2007-11-14 2:14 ` David Gibson
2007-11-14 3:40 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071114005734.GA19378@localhost.localdomain \
--to=dwg@au1.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=vbarshak@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.