From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jan Blunck <jblunck@suse.de>
Date: Wed, 14 Nov 2007 09:39:12 +0000
Subject: Re: blktrace segfault.
Message-Id: <20071114093912.GJ3767@hasse.suse.de>
List-Id: <linux-btrace.vger.kernel.org>
References: <4724673E.1090404@linux.vnet.ibm.com>
In-Reply-To: <4724673E.1090404@linux.vnet.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: linux-btrace@vger.kernel.org

On Sun, Oct 28, Aneesh Kumar K.V wrote:

>
> the below diff fix the same.
>
> diff --git a/blktrace.c b/blktrace.c
> index 42613a7..4f4fcde 100644
> --- a/blktrace.c
> +++ b/blktrace.c
> @@ -1220,6 +1220,7 @@ static int start_devices(void)
> 	size = ncpus * sizeof(struct thread_information);
> 	thread_information = malloc(size * ndevs);
> +	memset(thread_information, 0, size*ndevs);
> 	if (!thread_information) {
> 		fprintf(stderr, "Out of memory, threads (%d)\n", size * ndevs);
> 		return 1;

I'm pretty sure you want to make the memset after the NULL-pointer check. If
malloc fails this is segfaulting too.