All of lore.kernel.org
 help / color / mirror / Atom feed
From: fabbione@sourceware.org <fabbione@sourceware.org>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] cluster gfs/Makefile gfs2/mount/Makefile
Date: 14 Nov 2007 12:33:47 -0000	[thread overview]
Message-ID: <20071114123347.31526.qmail@sourceware.org> (raw)

CVSROOT:	/cvs/cluster
Module name:	cluster
Changes by:	fabbione at sourceware.org	2007-11-14 12:33:45

Modified files:
	gfs            : Makefile 
	gfs2/mount     : Makefile 

Log message:
	Hard encode paths to (u)mount.gfs*
	
	given the very nature of mount(8) api to look only in /sbin for (u)mount
	helpers, we can hard encode the install paths for our tools into the
	Makefile systems. I have never seen anywhere a different behavior in any
	Linux distribution and it will make packagers life simpler.
	
	Thanks also to Marc - A. Dahlhaus for spotting the missing DESTDIR
	entries.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/gfs/Makefile.diff?cvsroot=cluster&r1=1.12&r2=1.13
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/gfs2/mount/Makefile.diff?cvsroot=cluster&r1=1.18&r2=1.19

--- cluster/gfs/Makefile	2007/08/29 03:09:54	1.12
+++ cluster/gfs/Makefile	2007/11/14 12:33:45	1.13
@@ -24,10 +24,11 @@
 		${MAKE} -C $$i $@; \
 	done; \
 	if [ "$@" = "install" ]; then \
-		cd ${sbindir}; \
+		mkdir -p ${DESTDIR}/sbin; \
+		cd ${DESTDIR}/sbin; \
 			ln -sf mount.gfs2 mount.gfs; \
 			ln -sf umount.gfs2 umount.gfs; \
 	fi; \
 	if [ "$@" = "uninstall" ]; then \
-		cd ${sbindir}; rm -f mount.gfs umount.gfs; \
+		cd ${DESTDIR}/sbin; rm -f mount.gfs umount.gfs; \
 	fi
--- cluster/gfs2/mount/Makefile	2007/08/28 04:35:44	1.18
+++ cluster/gfs2/mount/Makefile	2007/11/14 12:33:45	1.19
@@ -41,11 +41,11 @@
 	$(CC) $(CFLAGS) -c -o $@ $<
 
 install: all
-	install ${TARGET1} ${sbindir}
-	install ${TARGET2} ${sbindir}
+	mkdir -p ${DESTDIR}/sbin
+	install ${TARGET1} ${TARGET2} ${DESTDIR}/sbin
 
 uninstall:
-	${UNINSTALL} ${TARGET1} ${TARGET2} ${sbindir}
+	${UNINSTALL} ${TARGET1} ${TARGET2} ${DESTDIR}/sbin
 
 clean:
 	rm -f *.o ${TARGET1} ${TARGET2}



                 reply	other threads:[~2007-11-14 12:33 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071114123347.31526.qmail@sourceware.org \
    --to=fabbione@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.