From: Jens Axboe <jens.axboe@oracle.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Attempt to get eject failures back to ioctl(CDROMEJECT)
Date: Wed, 14 Nov 2007 13:39:31 +0100 [thread overview]
Message-ID: <20071114123931.GF5064@kernel.dk> (raw)
In-Reply-To: <200711141739.46960.rusty@rustcorp.com.au>
On Wed, Nov 14 2007, Rusty Russell wrote:
> Hi Jens,
>
> As you asked for some time ago. Of course, it turns out that the eject
> command ignores the error anyway, but it's nice that it now errors.
>
> Not entirely comfortable with this patch: there's a req->errors but
> that seems to have some existing semantics I'm not sure of, so I simply
> added a new way of flagging an error.
It is a bit of a hack, but it's not really your fault. ->errors is
somewhat messy and has different meaning depending on the request type.
I'll add your patch and then do a sanitize on top of it, so that we can
switch things over to a unified ->errno instead.
--
Jens Axboe
next prev parent reply other threads:[~2007-11-14 12:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-14 6:39 [PATCH] Attempt to get eject failures back to ioctl(CDROMEJECT) Rusty Russell
2007-11-14 12:39 ` Jens Axboe [this message]
2007-11-15 2:35 ` Rusty Russell
2007-11-15 8:47 ` Jens Axboe
2007-11-15 11:32 ` Rusty Russell
2007-11-15 11:35 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071114123931.GF5064@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.