All of lore.kernel.org
 help / color / mirror / Atom feed
From: "John W. Linville" <linville@tuxdriver.com>
To: Will Dyson <will.dyson@gmail.com>
Cc: Florian Lohoff <flo@rfc822.org>, Marcus Better <marcus@better.se>,
	linux-wireless@vger.kernel.org
Subject: Re: rt2x00/rt2500 PCI unresponsive / sluggish response
Date: Wed, 14 Nov 2007 16:13:55 -0500	[thread overview]
Message-ID: <20071114211354.GD6226@tuxdriver.com> (raw)
In-Reply-To: <8e6f94720711141057w463d55c4r2be74d0aa8d78918@mail.gmail.com>

On Wed, Nov 14, 2007 at 01:57:52PM -0500, Will Dyson wrote:
> On Nov 14, 2007 10:33 AM, Florian Lohoff <flo@rfc822.org> wrote:
> 
> > Did you actually try setting the rate manually? I just tried
> > when i came home from work. I set it to 36MBit/s and it actually
> > works ... I am now transferring with 2.5MByte/s instead of 30Kbyte/s
> >
> > So i guess the auto rate selection is broken ... Or 1 MBit/s is default
> > or something ...
> 
> Ah, that is probably this isssue:
> 
> http://git.kernel.org/gitweb.cgi?p=linux/kernel/git/ivd/rt2x00.git;a=commit;h=d37cabfb5f60a3bb56585a74fd3f140ba2960fe0
> 
> The patch is in the wireless-2.6/everything tree, but not Linus's tree.

Most of the patch seems like a no-op, except this bit:

 	if (is_rts_frame(frame_control) || is_cts_frame(frame_control)) {
 		__set_bit(ENTRY_TXD_BURST, &desc.flags);
-		if (is_rts_frame(frame_control))
+		if (is_rts_frame(frame_control)) {
 			__set_bit(ENTRY_TXD_RTS_FRAME, &desc.flags);
+			__set_bit(ENTRY_TXD_ACK, &desc.flags);
+		} else
+			__clear_bit(ENTRY_TXD_ACK, &desc.flags);
 		if (control->rts_cts_rate)
 			tx_rate = control->rts_cts_rate;
 	}

Is this correct?  I'm not sure about the actual meaning of TXD_W0_ACK
(which keys off ENTRY_TXD_ACK)...

John
-- 
John W. Linville
linville@tuxdriver.com

  reply	other threads:[~2007-11-14 21:14 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-11 10:23 rt2x00/rt2500 PCI unresponsive / sluggish response Florian Lohoff
2007-11-12 22:59 ` Will Dyson
2007-11-13 19:23   ` Florian Lohoff
2007-11-14  8:58     ` Marcus Better
2007-11-14 12:17       ` Florian Lohoff
2007-11-14 12:19         ` Marcus Better
2007-11-15  1:20           ` John W. Linville
2007-11-14 15:33       ` Florian Lohoff
2007-11-14 18:57         ` Will Dyson
2007-11-14 21:13           ` John W. Linville [this message]
2007-11-15  2:40             ` Will Dyson
2007-11-15 10:11               ` Mattias Nissler
2007-11-15 19:58                 ` Ivo van Doorn
2007-11-15 19:48                   ` Mattias Nissler
2007-11-15 22:59                     ` Ivo van Doorn
2007-11-15  8:48         ` Marcus Better

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071114211354.GD6226@tuxdriver.com \
    --to=linville@tuxdriver.com \
    --cc=flo@rfc822.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=marcus@better.se \
    --cc=will.dyson@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.