All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Shannon Nelson <shannon.nelson@intel.com>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	hskinnemoen@atmel.com, stable@kernel.org
Subject: Re: [stable] [PATCH] dmaengine: Fix broken device refcounting
Date: Wed, 14 Nov 2007 13:45:43 -0800	[thread overview]
Message-ID: <20071114214543.GC9901@kroah.com> (raw)
In-Reply-To: <1194461167.8489.6.camel@dwillia2-linux.ch.intel.com>

On Wed, Nov 07, 2007 at 11:46:07AM -0700, Dan Williams wrote:
> From: Haavard Skinnemoen <hskinnemoen@atmel.com>
> 
> When a DMA device is unregistered, its reference count is decremented
> twice for each channel: Once dma_class_dev_release() and once in
> dma_chan_cleanup(). This may result in the DMA device driver's
> remove() function completing before all channels have been cleaned
> up, causing lots of use-after-free fun.
> 
> Fix it by incrementing the device's reference count twice for each
> channel during registration.
> 
> Signed-off-by: Haavard Skinnemoen <hskinnemoen@atmel.com>
> [dan.j.williams@intel.com: kill unnecessary client refcounting]
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
> Signed-off-by: Shannon Nelson <shannon.nelson@intel.com>
> Cc: stable@kernel.org

I don't see this in Linus's tree yet, right?

When it goes in, can you resend it to the stable@kernel.org people?

thanks,

greg k-h

      reply	other threads:[~2007-11-14 21:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-07 18:46 [PATCH] dmaengine: Fix broken device refcounting Dan Williams
2007-11-14 21:45 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071114214543.GC9901@kroah.com \
    --to=greg@kroah.com \
    --cc=akpm@linux-foundation.org \
    --cc=dan.j.williams@intel.com \
    --cc=hskinnemoen@atmel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shannon.nelson@intel.com \
    --cc=stable@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.