From: Jarek Poplawski <jarkao2@o2.pl>
To: Stephen Hemminger <shemminger@linux-foundation.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
"David S\. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, jnelson-kernel-bugzilla@jamponi.net
Subject: Re: [PATCH] via-velocity: don't oops on MTU change.
Date: Thu, 15 Nov 2007 09:26:00 +0100 [thread overview]
Message-ID: <20071115082600.GA2366@ff.dom.local> (raw)
In-Reply-To: <20071114193844.0cab5c7d@freepuppy.rosehill>
On 15-11-2007 04:38, Stephen Hemminger wrote:
> Simple mtu change when device is down.
> Fix http://bugzilla.kernel.org/show_bug.cgi?id=9382.
>
> Signed-off-by: Stephen Hemminger <shemminger@linux-foundation.org>
>
>
> --- a/drivers/net/via-velocity.c 2007-10-22 09:38:11.000000000 -0700
> +++ b/drivers/net/via-velocity.c 2007-11-14 19:34:30.000000000 -0800
> @@ -1963,6 +1963,11 @@ static int velocity_change_mtu(struct ne
> return -EINVAL;
> }
>
> + if (!netif_running(dev)) {
> + dev->mtu = new_mtu;
> + return 0;
> + }
> +
> if (new_mtu != oldmtu) {
> spin_lock_irqsave(&vptr->lock, flags);
Shouldn't this latter 'if' be removed now, btw?
Regards,
Jarek P.
next prev parent reply other threads:[~2007-11-15 8:21 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <bug-9382-10286@http.bugzilla.kernel.org/>
2007-11-15 3:23 ` [Bugme-new] [Bug 9382] New: etting MTU > 1500 on card "cold" sigsegs the "ip" program and produces an OOPS Andrew Morton
2007-11-15 3:38 ` [PATCH] via-velocity: don't oops on MTU change Stephen Hemminger
2007-11-15 3:48 ` David Miller
2007-11-15 8:26 ` Jarek Poplawski [this message]
2007-11-15 18:20 ` Stephen Hemminger
2007-11-15 23:10 ` Jarek Poplawski
2007-11-16 2:42 ` Jon Nelson
2007-11-16 4:05 ` Stephen Hemminger
2007-11-16 4:35 ` Stephen Hemminger
2007-11-16 16:21 ` Jon Nelson
2007-11-16 16:47 ` Stephen Hemminger
2007-11-17 0:25 ` David Miller
2007-11-17 0:59 ` Jon Nelson
2007-11-17 15:04 ` Jarek Poplawski
2007-11-28 22:02 ` Jon Nelson
2007-11-28 22:20 ` [PATCH] via-velocity: don't oops on MTU change (resend) Stephen Hemminger
2007-12-01 21:36 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071115082600.GA2366@ff.dom.local \
--to=jarkao2@o2.pl \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=jnelson-kernel-bugzilla@jamponi.net \
--cc=netdev@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.