From: Alex Chiang <achiang@hp.com>
To: Rolf Eike Beer <eike-hotplug@sf-tec.de>
Cc: Matthew Wilcox <matthew@wil.cx>, Gary Hade <garyhade@us.ibm.com>,
Greg KH <greg@kroah.com>,
gregkh@suse.de, kristen.c.accardi@intel.com, lenb@kernel.org,
rick.jones2@hp.com, linux-kernel@vger.kernel.org,
linux-pci@atrey.karlin.mff.cuni.cz,
kaneshige.kenji@jp.fujitsu.com,
pcihpd-discuss@lists.sourceforge.net, linux-acpi@vger.kernel.org
Subject: Re: [PATCH 2/5] Construct one fakephp slot per pci slot
Date: Thu, 15 Nov 2007 10:40:15 -0700 [thread overview]
Message-ID: <20071115174015.GI7541@ldl.fc.hp.com> (raw)
In-Reply-To: <200711151258.02696.eike-hotplug@sf-tec.de>
* Rolf Eike Beer <eike-hotplug@sf-tec.de>:
> Am Mittwoch, 14. November 2007 schrieb Alex Chiang:
> > * Matthew Wilcox <matthew@wil.cx>:
> > > On Wed, Nov 14, 2007 at 12:37:29PM -0700, Alex Chiang
> > > > Register one slot per slot, rather than one slot per
> > > > function. Change the name of the slot to fake%d instead
> > > > of the pci address.
> > > >
> > > > +#define SLOT_NAME_SIZE KOBJ_NAME_LEN
> > >
> > > Defined, then never used ... how about s/KOBJ_NAME_LEN/8/,
> > > then use SLOT_NAME_SIZE throughout?
> >
> > Whoops, good catch. I had a braino there.
>
> Just drop it and use sizeof(dslot->name) in snprintf(). Just be
> careful not to use slot->name there as it would always be
> sizeof(void*)!
Thanks, even better.
/ac
next prev parent reply other threads:[~2007-11-15 17:40 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-14 19:36 [PATCH 0/5, v2] Physical PCI slot objects Alex Chiang
2007-11-14 19:37 ` [PATCH 1/5] Remove path attribute from sgi_hotplug Alex Chiang
2007-11-14 19:37 ` Alex Chiang
2007-11-14 19:37 ` [PATCH 2/5] Construct one fakephp slot per pci slot Alex Chiang
2007-11-14 19:37 ` Alex Chiang
2007-11-14 20:12 ` Matthew Wilcox
2007-11-14 20:12 ` Matthew Wilcox
2007-11-14 20:55 ` Alex Chiang
2007-11-15 11:57 ` Rolf Eike Beer
2007-11-15 17:40 ` Alex Chiang [this message]
2007-11-14 21:04 ` Alex Chiang
2007-11-14 19:37 ` [PATCH 3/5] Introduce pci_slot Alex Chiang
2007-11-14 19:37 ` Alex Chiang
2007-11-14 19:38 ` [PATCH 4/5] Add pci_slot_add_hotplug() Alex Chiang
2007-11-14 19:38 ` Alex Chiang
2007-11-14 19:39 ` [PATCH 5/5] ACPI PCI slot detection driver Alex Chiang
2007-11-14 19:39 ` Alex Chiang
2007-11-15 0:39 ` [PATCH 0/5, v2] Physical PCI slot objects Gary Hade
-- strict thread matches above, loose matches on Subject: below --
2007-11-13 0:08 [PATCH 0/5][RFC] " Alex Chiang
2007-11-13 0:13 ` [PATCH 2/5] Construct one fakephp slot per pci slot Alex Chiang
2007-11-13 0:13 ` Alex Chiang
2007-11-13 19:48 ` Linas Vepstas
2007-11-13 19:52 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071115174015.GI7541@ldl.fc.hp.com \
--to=achiang@hp.com \
--cc=eike-hotplug@sf-tec.de \
--cc=garyhade@us.ibm.com \
--cc=greg@kroah.com \
--cc=gregkh@suse.de \
--cc=kaneshige.kenji@jp.fujitsu.com \
--cc=kristen.c.accardi@intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=matthew@wil.cx \
--cc=pcihpd-discuss@lists.sourceforge.net \
--cc=rick.jones2@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.