All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Kevin Hilman <khilman@mvista.com>
Cc: linux-omap-open-source@linux.omap.com
Subject: Re: [PATCH resend] ARM: OMAP: clk_disable_unused: init section mismatch
Date: Thu, 15 Nov 2007 12:54:47 -0800	[thread overview]
Message-ID: <20071115205447.GI20686@atomide.com> (raw)
In-Reply-To: <20071102001202.021061363@mvista.com>

* Kevin Hilman <khilman@mvista.com> [071101 17:13]:
> Fix the following warning when OMAP_RESET_CLOCKS is enabled:
> 
> WARNING: vmlinux.o(.data+0x33a0): Section mismatch: reference to .init.text:omap2_clk_disable_unused (between 'omap2_clk_functions' and 'osc_ck')
> 
> omap2_clk_disable_unused cannot be declared __init as it part of a
> struct where the rest of the functions are not __init.
> 
> Signed-off-by: Kevin Hilman <khilman@mvista.com>
> 
> ---
>  arch/arm/mach-omap2/clock.c |    2 +-
>  arch/arm/mach-omap2/clock.h |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> Index: dev/arch/arm/mach-omap2/clock.c
> ===================================================================
> --- dev.orig/arch/arm/mach-omap2/clock.c
> +++ dev/arch/arm/mach-omap2/clock.c
> @@ -739,7 +739,7 @@ int omap2_clk_set_parent(struct clk *clk
>   *-------------------------------------------------------------------------*/
>  
>  #ifdef CONFIG_OMAP_RESET_CLOCKS
> -void __init omap2_clk_disable_unused(struct clk *clk)
> +void omap2_clk_disable_unused(struct clk *clk)
>  {
>  	u32 regval32, v;
>  
> Index: dev/arch/arm/mach-omap2/clock.h
> ===================================================================
> --- dev.orig/arch/arm/mach-omap2/clock.h
> +++ dev/arch/arm/mach-omap2/clock.h
> @@ -30,7 +30,7 @@ int omap2_clk_set_rate(struct clk *clk, 
>  int omap2_clk_set_parent(struct clk *clk, struct clk *new_parent);
>  
>  #ifdef CONFIG_OMAP_RESET_CLOCKS
> -void __init omap2_clk_disable_unused(struct clk *clk);
> +void omap2_clk_disable_unused(struct clk *clk);
>  #else
>  #define omap2_clk_disable_unused	NULL
>  #endif

Oops, pushing this updated version instead :)

Tony

      reply	other threads:[~2007-11-15 20:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-02  0:12 [PATCH resend] ARM: OMAP: clk_disable_unused: init section mismatch Kevin Hilman
2007-11-15 20:54 ` Tony Lindgren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071115205447.GI20686@atomide.com \
    --to=tony@atomide.com \
    --cc=khilman@mvista.com \
    --cc=linux-omap-open-source@linux.omap.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.