Re: [PATCH 10/13] ide-cris: fix DMA methods

[Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>]

On Wednesday 14 November 2007, Sergei Shtylyov wrote:
> Bartlomiej Zolnierkiewicz wrote:
> 
> > * Rename cris_dma_{on,off}() to cris_dma_host_{on,off}().
> 
>     Haven't you killed dma_on/dma_off_quietly() methods in the previosu patch?

Yes, I did.

I left fixing ide-cris after "kill dma_on/dma_off_quietly() methods"
patch because:

* Currently this driver is broken: cris_dma_on() (returns 'int')
  is assigned to hwif->dma_host_on (returns 'void') so the driver
  won't build.

* ->ide_dma_on method was missing so the driver OOPS-es on attempt
  to enable DMA.

* drive->using_dma was never set/cleared so DMA wouldn't be used anyway.

Unfortunately it seems that ide-cris stays broken even after this patch:

* V10: <asm/arch-v10/ide.h> needs fixing
  - ide_init_default_hwifs() should be removed
    (IDE core no longer uses it)
  - same for ide_init_hwif_ports() and ide_default_{irq,io_base}()
    (they shouldn't be needed for ide-cris host driver)

* V32: I'm unable to find a place which defines ETRAX_ARCH_V32

but I'm leaving fixing this to CRIS gurus. :)

[ I added the above explanation to the patch description. ]

> > * Remove no longer needed ->dma_off_quietly
> >   (IDE core has the needed code now).
> 
> > * Make cris_dma_host_on() void.
> 
> > Cc: Mikael Starvik <starvik@axis.com>
> > Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>