From: Michael Buesch <mb@bu3sch.de>
To: Larry Finger <larry.finger@lwfinger.net>
Cc: seandarcy2@gmail.com, Bcm43xx-dev@lists.berlios.de,
linux-wireless@vger.kernel.org
Subject: Re: [RFC/T] b43: Implement the BCM94311MCG rev 02 card with a rev 13 802.11 core
Date: Thu, 15 Nov 2007 22:49:12 +0100 [thread overview]
Message-ID: <200711152249.12824.mb@bu3sch.de> (raw)
In-Reply-To: <473C5F98.1050007@lwfinger.net>
On Thursday 15 November 2007 16:02:48 Larry Finger wrote:
> >> @@ -695,11 +687,12 @@ static int dmacontroller_setup(struct b4
> >> b43_dma_write(ring, B43_DMA32_RXRING,
> >> (ringbase & ~SSB_DMA_TRANSLATION_MASK)
> >> | trans);
> >> - b43_dma_write(ring, B43_DMA32_RXINDEX, 200);
> >> + b43_dma_write(ring, B43_DMA32_RXINDEX, ring->nr_slots *
> >> + sizeof(struct b43_dmadesc32));
> >
> > I'm not sure why you do this change.
>
> It took me a while to figure out where the magic number of 200 came from, and what I needed for the
> 64-bit case. In fact I think the 200 is a bug and should be 0x200. To me, this change makes it clearer.
The 200 is just a random number.
I think we don't really care what the value is. (Except zero, which doesn't
work on some devices).
--
Greetings Michael.
next prev parent reply other threads:[~2007-11-15 21:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-15 5:55 [RFC/T] b43: Implement the BCM94311MCG rev 02 card with a rev 13 802.11 core Larry Finger
2007-11-15 10:38 ` Michael Buesch
2007-11-15 15:02 ` Larry Finger
2007-11-15 21:49 ` Michael Buesch [this message]
2007-11-15 23:11 ` Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200711152249.12824.mb@bu3sch.de \
--to=mb@bu3sch.de \
--cc=Bcm43xx-dev@lists.berlios.de \
--cc=larry.finger@lwfinger.net \
--cc=linux-wireless@vger.kernel.org \
--cc=seandarcy2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.