From: Christoph Hellwig <hch@infradead.org>
To: David Chinner <dgc@sgi.com>
Cc: Lachlan McIlroy <lachlan@sgi.com>, xfs-oss <xfs@oss.sgi.com>,
xfs-dev <xfs-dev@sgi.com>
Subject: Re: [PATCH, RFC] Move AIL pushing into a separate thread
Date: Fri, 16 Nov 2007 07:23:13 +0000 [thread overview]
Message-ID: <20071116072313.GA17009@infradead.org> (raw)
In-Reply-To: <20071116004310.GL66820511@sgi.com>
On Fri, Nov 16, 2007 at 11:43:10AM +1100, David Chinner wrote:
> > >+ /* Too many items we can't do anything with? */
> > >+ if (stuck > 100)
> > 100? Arbitrary magic number or was there reason for this?
>
> Arbitrary magic number based on observation. basically, if
> we are skipping too many items because we can't flush them or
> they are already being flushed we back off and given them time
> to complete whatever operation is being done. i.e. remove pressure
> from the AIL while we can't make progress so traversals don't
> slow down further inserts and remov?ls to/from the AIL.
Might be worth adding something like this as a comment.
prev parent reply other threads:[~2007-11-16 7:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-05 5:07 [PATCH, RFC] Move AIL pushing into a separate thread David Chinner
2007-11-09 0:34 ` Lachlan McIlroy
2007-11-09 3:16 ` David Chinner
2007-11-15 3:32 ` Lachlan McIlroy
2007-11-16 0:43 ` David Chinner
2007-11-16 1:19 ` Lachlan McIlroy
2007-11-16 7:23 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071116072313.GA17009@infradead.org \
--to=hch@infradead.org \
--cc=dgc@sgi.com \
--cc=lachlan@sgi.com \
--cc=xfs-dev@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.