From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Daniel P. Berrange" Subject: Re: Re: Xend transaction reduction breaks migration Date: Fri, 16 Nov 2007 14:00:38 +0000 Message-ID: <20071116140038.GA8386@redhat.com> References: Reply-To: "Daniel P. Berrange" Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Keir Fraser Cc: xen-devel List-Id: xen-devel@lists.xenproject.org On Thu, Nov 15, 2007 at 10:11:29PM +0000, Keir Fraser wrote: > On 15/11/07 18:46, "Keir Fraser" wrote: > > > On 15/11/07 18:39, "Daniel P. Berrange" wrote: > > > >> all happen in one large transaction. Oddly though, I tried to be careful so > >> that I only changed the codepath for the 'xm list' operation (well the SEXPR > >> call to the list operation). Other operations like create, save, restore > >> ought to be left using fine grained transactions as before. > > > > I'll have another look at nearby changesets in xen-unstable then. Yours > > doesn't really look all that likely to cause this problem, except that the > > empirical evidence does point at it. > > It is your patch. The readDomTxn() functions and friends should prepend the > dompath, not the vmpath. Aha. Thanks for finding & fixing that. Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|