From: "Jörn Engel" <joern@logfs.org>
To: Andre Haupt <andre@bitwigglers.org>
Cc: joern@wh.fh-wedel.de, linux-mtd@lists.infradead.org
Subject: Re: [PATCH] cfi: make cfi_staa_erase_varsize static to shut up sparse
Date: Fri, 16 Nov 2007 15:10:15 +0100 [thread overview]
Message-ID: <20071116141015.GB17372@lazybastard.org> (raw)
In-Reply-To: <11952197951426-git-send-email-andre@bitwigglers.org>
On Fri, 16 November 2007 14:29:55 +0100, Andre Haupt wrote:
>
> should this be static?
Looks like it.
> From: Andre Haupt <andre@bitwigglers.org>
> Signed-off-by: Andre Haupt <andre@bitwigglers.org>
Acked-by: Joern Engel <joern@logfs.org>
> ---
> drivers/mtd/chips/cfi_cmdset_0020.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mtd/chips/cfi_cmdset_0020.c b/drivers/mtd/chips/cfi_cmdset_0020.c
> index b344ff8..07a3dd4 100644
> --- a/drivers/mtd/chips/cfi_cmdset_0020.c
> +++ b/drivers/mtd/chips/cfi_cmdset_0020.c
> @@ -893,7 +893,7 @@ retry:
> return ret;
> }
>
> -int cfi_staa_erase_varsize(struct mtd_info *mtd, struct erase_info *instr)
> +static int cfi_staa_erase_varsize(struct mtd_info *mtd, struct erase_info *instr)
> { struct map_info *map = mtd->priv;
> struct cfi_private *cfi = map->fldrv_priv;
> unsigned long adr, len;
> --
> 1.4.4.4
>
Jörn
--
The strong give up and move away, while the weak give up and stay.
-- unknown
prev parent reply other threads:[~2007-11-16 14:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-16 13:29 [PATCH] cfi: make cfi_staa_erase_varsize static to shut up sparse Andre Haupt
2007-11-16 14:10 ` Jörn Engel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071116141015.GB17372@lazybastard.org \
--to=joern@logfs.org \
--cc=andre@bitwigglers.org \
--cc=joern@wh.fh-wedel.de \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.