Re: [PATCH] nfsd: fail module init on reply cache init failure

["J. Bruce Fields" <bfields@fieldses.org>]

On Fri, Nov 16, 2007 at 11:22:24AM -0500, Peter Staubach wrote:
> J. Bruce Fields wrote:
>> On Fri, Nov 16, 2007 at 10:38:47AM -0500, Peter Staubach wrote:
>>   
>>> J. Bruce Fields wrote:
>>>     
>>>> On Fri, Nov 16, 2007 at 09:29:21AM -0500, Peter Staubach wrote:
>>>>         
>>>>> J. Bruce Fields wrote:
>>>>>             
>>>>>> +	printk(KERN_ERR "nfsd: failed to allocate reply cache\n");
>>>>>>                   
>>>>> I was thinking that it might be nice to have something which
>>>>> better explains what the ramifications of this failure might
>>>>> be.  This explains _precisely_ what happened, but not what
>>>>> will happen in the future.
>>>>>             
>>>> The module will fail to load (or, I suppose, the kernel will fail to
>>>> boot?).  So the failure will be pretty obvious.
>>>>
>>>>         
>>> The module will fail to load, but I suspect that that won't cause
>>> the system to fail to boot.
>>>     
>>
>> OK, but I was thinking of the case where nfsd was built in.
>>
>>   
>
> Ahh.  Sorry, didn't think about that.
>
> This seems a little strong, doesn't it?  To cause the system
> to fail to boot?

Yeah, and I was confused: it's init/main.c:do_initcalls() that does
this, and it just keeps going regardless (and doesn't even log the error
unless debugging is turned on).  That makes more sense.

--b.

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs
_______________________________________________
Please note that nfs@lists.sourceforge.net is being discontinued.
Please subscribe to linux-nfs@vger.kernel.org instead.
    http://vger.kernel.org/vger-lists.html#linux-nfs