All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@kernel.org>
To: Andreas Mohr <andi@lisas.de>
Cc: Randy Dunlap <randy.dunlap@oracle.com>,
	Andrew Morton <akpm@osdl.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH/RFC] eradicate bashisms in scripts/patch-kernel
Date: Sat, 17 Nov 2007 18:24:46 +0100	[thread overview]
Message-ID: <20071117172446.GD4250@stusta.de> (raw)
In-Reply-To: <20071031211321.GA8363@rhlx01.hs-esslingen.de>

On Wed, Oct 31, 2007 at 10:13:21PM +0100, Andreas Mohr wrote:

> Hello,

Hi Andreas,

> I was non-mildly horrified to find that the rather widely used patch-kernel
> script seems to rely on bash despite specifying the interpreter as #!/bin/sh,
> since my dash-using Debian install choked on it.
> 
> Thus I'm delivering a first, preliminary, non-reviewed change to make
> patch-kernel (a little bit more?) POSIX-compatible. It now survives both
> a dash and a bash run.
>...
> Comments?
>...

if that's easyly possible it's OK.

But if it becomes possible I'd strongly favour simply changing the 
interpreter to #!/bin/bash which would also fix this problem.

> Thanks,
> 
> Andreas Mohr
>...

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


      parent reply	other threads:[~2007-11-17 17:25 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-31 21:13 [PATCH/RFC] eradicate bashisms in scripts/patch-kernel Andreas Mohr
2007-10-31 22:24 ` Randy Dunlap
2007-11-01 12:11   ` Andreas Mohr
2007-11-01 15:24     ` Randy Dunlap
2007-11-01 22:16       ` Andreas Mohr
2007-11-01 23:08         ` Randy Dunlap
2007-11-02  2:01           ` Herbert Xu
2007-11-02 20:09             ` Andreas Mohr
2007-11-02 20:17               ` Randy Dunlap
2007-11-05 19:58                 ` Andreas Mohr
2007-11-14 22:46                   ` Randy Dunlap
2007-11-17 16:33                     ` Andreas Mohr
2007-11-17 16:43                       ` Herbert Xu
2007-11-17 17:28                       ` Sam Ravnborg
2007-11-17 20:51                         ` [PATCH] " Andreas Mohr
2008-01-02 23:00                           ` Randy Dunlap
2011-04-03 18:58                           ` [PATCH] " Andreas Mohr
2011-04-03 19:40                             ` Randy Dunlap
2011-04-21 11:36                               ` Andreas Mohr
2011-04-04 12:59                             ` Michal Marek
2007-11-17 17:24 ` Adrian Bunk [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071117172446.GD4250@stusta.de \
    --to=bunk@kernel.org \
    --cc=akpm@osdl.org \
    --cc=andi@lisas.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=randy.dunlap@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.