All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Wong <normalperson@yhbt.net>
To: "Konstantin V. Arkhipov" <voxus@onphp.org>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] git-svn's dcommit must use subversion's config
Date: Sat, 17 Nov 2007 13:22:41 -0800	[thread overview]
Message-ID: <20071117212241.GA22835@soma> (raw)
In-Reply-To: <200711140352.02978.voxus@onphp.org>

"Konstantin V. Arkhipov" <voxus@onphp.org> wrote:
> When doing dcommit git-svn must use subversion's config or newly created
> files will not include svn's properties
> (defined in [auto-props] with 'enable-auto-props = yes').
> 
> Signed-off-by: Konstantin V. Arkhipov <voxus@onphp.org>

> ---
> --- git-svn	2007-11-02 18:41:32.000000000 +0300
> +++ git-svn	2007-11-12 19:35:44.000000000 +0300

Thanks Konstantin,

I needed to add '.perl' to the filenames above to get the patch to
apply.  But otherwise,

Acked-by: Eric Wong <normalperson@yhbt.net>

> @@ -406,6 +406,9 @@ sub cmd_dcommit {
>  			my %ed_opts = ( r => $last_rev,
>  			                log => get_commit_entry($d)->{log},
>  			                ra => Git::SVN::Ra->new($gs->full_url),
> +			                config => SVN::Core::config_get_config(
> +			                        $Git::SVN::Ra::config_dir
> +			                ),
>  			                tree_a => "$d~1",
>  			                tree_b => $d,
>  			                editor_cb => sub {

-- 
Eric Wong

      reply	other threads:[~2007-11-17 21:23 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-14  0:52 [PATCH] git-svn's dcommit must use subversion's config Konstantin V. Arkhipov
2007-11-17 21:22 ` Eric Wong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071117212241.GA22835@soma \
    --to=normalperson@yhbt.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=voxus@onphp.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.