From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Itdzu-0002fG-Rs for mharc-grub-devel@gnu.org; Sun, 18 Nov 2007 01:51:14 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Itdzs-0002aU-Cb for grub-devel@gnu.org; Sun, 18 Nov 2007 01:51:12 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Itdzr-0002Xo-8f for grub-devel@gnu.org; Sun, 18 Nov 2007 01:51:11 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Itdzr-0002Xb-2y for grub-devel@gnu.org; Sun, 18 Nov 2007 01:51:11 -0500 Received: from aybabtu.com ([69.60.117.155]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Itdzq-0006P7-Jf for grub-devel@gnu.org; Sun, 18 Nov 2007 01:51:10 -0500 Received: from [192.168.10.6] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1Itdzp-0005GS-3k for grub-devel@gnu.org; Sun, 18 Nov 2007 07:51:09 +0100 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1ItdzX-0000nt-S9 for grub-devel@gnu.org; Sun, 18 Nov 2007 07:50:52 +0100 Date: Sun, 18 Nov 2007 07:50:51 +0100 From: Robert Millan To: The development of GRUB 2 Message-ID: <20071118065051.GE20719@thorin> References: <1195025942.22086.11.camel@dv> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1195025942.22086.11.camel@dv> Organization: free as in freedom X-Message-Flag: Microsoft discourages use of Outlook. X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] Fix for linker build ID in Fedora 8 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Nov 2007 06:51:12 -0000 On Wed, Nov 14, 2007 at 02:39:02AM -0500, Pavel Roskin wrote: > Hello! > > [Sorry for not replying earlier. All messages from my gnu.org account > were getting lost. Anyway, I'll need to retire that address due to > massive spam.] > > Here's an alternate patch for the issue that appeared on Fedora 8. The > linker adds a "build ID" (.not.gnu.build-id) by default. That section > makes objcopy create output files about 128M long when asked to use > binary format. Needless to say, they are not suitable as grub images. > Also, the build ID section breaks the test for objcopy in the configure > script. > > This patch is less intrusive than the one I posted earlier, so I hope it > will be accepted. > > 2007-10-29 Pavel Roskin > > * configure.ac: Test if '--build-id=none' is supported by the > linker. Add it to TARGET_LDFLAGS if possible. Build ID > interferes with objcopy. > * aclocal.m4 (grub_PROG_OBJCOPY_ABSOLUTE): Use LDFLAGS when > linking, so that build ID doesn't break the test. Looks fine to me. Seeing that there were no objections after a few days, I suggest you check it in. -- Robert Millan I know my rights; I want my phone call! What use is a phone call, if you are unable to speak? (as seen on /.)