All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] Fix u16 status declaration when PCMCIA	is defined
Date: Sun, 18 Nov 2007 17:28:29 +0100	[thread overview]
Message-ID: <20071118162829.GA4286@game.jcrosoft.org> (raw)
In-Reply-To: <20071118152751.B8783243A9@gemini.denx.de>

On 16:27 Sun 18 Nov     , Wolfgang Denk wrote:
> In message <1195386902-15477-1-git-send-email-plagnioj@jcrosoft.com> you wrote:
> > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> > 
> > diff --git a/board/pb1x00/pb1x00.c b/board/pb1x00/pb1x00.c
> > index 95b7d82..536c954 100644
> > --- a/board/pb1x00/pb1x00.c
> > +++ b/board/pb1x00/pb1x00.c
> > @@ -42,7 +42,9 @@ void write_one_tlb( int index, u32 pagemask, u32 hi, u32 low0, u32 low1 );
> >  
> >  int checkboard (void)
> >  {
> > +#if defined(CONFIG_IDE_PCMCIA) && 0
> 
> Oops? What is the meaning of the "&& 0" here ???
> 
> There are less cryptic ways to comment out a line of code, it seems.
> 

I agree, but I've chose the same that the line 78.

If you prefer I can as fallowing

#if 0
#if defined(CONFIG_IDE_PCMCIA)

...

#endif
#endif

Best Regards.
J.

  reply	other threads:[~2007-11-18 16:28 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-18 11:55 [U-Boot-Users] [PATCH] Fix u16 status declaration when PCMCIA is defined Jean-Christophe PLAGNIOL-VILLARD
2007-11-18 15:27 ` Wolfgang Denk
2007-11-18 16:28   ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2007-11-18 19:32     ` Wolfgang Denk
2007-11-18 17:16       ` Jean-Christophe PLAGNIOL-VILLARD
2007-11-18 20:49 ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071118162829.GA4286@game.jcrosoft.org \
    --to=plagnioj@jcrosoft.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.