From: Andreas Herrmann <aherrman@arcor.de>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Sam Ravnborg <sam@ravnborg.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
Roman Zippel <zippel@linux-m68k.org>,
LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: [PATCH] x86: fix UTS_MACHINE to be i386 for 32-bit build and x86_64 for 64-bit build
Date: Mon, 19 Nov 2007 10:34:37 +0100 [thread overview]
Message-ID: <20071119093437.GA5104@devil> (raw)
In-Reply-To: <20071117143731.GA7129@uranus.ravnborg.org>
On Sat, Nov 17, 2007 at 03:37:31PM +0100, Sam Ravnborg wrote:
>
> Note: This patch does not fix the uname -m issue - to do so
> Andreas' patch is needed.
>
> Sam
Linus,
The issue Sam refers to is that UTS_MACHINE is set to "x86" instead of
"i386" or "x86_64" when building with ARCH=x86. Thus the new kernel
when booted will give either "x86" on x86_64 and many i386 systems or
even "x66" on other i386 systems for 'uname -m'.
Many tools rely on the usual values of "x86_64", "i366" and "i686"
here. So we shouldn't change this.
Attached patch fixes that issue. Please apply.
Regards,
Andreas
--
x86: fix UTS_MACHINE to be i386 for 32-bit build and x86_64 for 64-bit build
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: Roman Zippel <zippel@linux-m68k.org>
Signed-off-by: Andreas Herrmann <aherrman@arcor.de>
---
arch/x86/Makefile | 5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/arch/x86/Makefile b/arch/x86/Makefile
index 116b03a..7aa1dc6 100644
--- a/arch/x86/Makefile
+++ b/arch/x86/Makefile
@@ -11,10 +11,9 @@ endif
$(srctree)/arch/x86/Makefile%: ;
ifeq ($(CONFIG_X86_32),y)
+ UTS_MACHINE := i386
include $(srctree)/arch/x86/Makefile_32
else
+ UTS_MACHINE := x86_64
include $(srctree)/arch/x86/Makefile_64
endif
-
-
-
--
1.5.3.4
next prev parent reply other threads:[~2007-11-19 9:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-17 14:37 [PATCH] x86: simplify "make ARCH=x86" and fix kconfig all.config Sam Ravnborg
2007-11-19 9:34 ` Andreas Herrmann [this message]
2007-11-19 10:41 ` [PATCH] x86: fix UTS_MACHINE to be i386 for 32-bit build and x86_64 for 64-bit build Sam Ravnborg
2007-11-19 16:00 ` Andreas Herrmann
2007-11-19 22:58 ` [PATCH] x86: correctly set UTS_MACHINE for "make ARCH=x86" Andreas Herrmann
-- strict thread matches above, loose matches on Subject: below --
2007-11-16 11:14 Kconfig: ARCH=x86 Andreas Herrmann
2007-11-16 12:37 ` Kconfig: ARCH=x86 causes wrong utsname.machine Andreas Herrmann
2007-11-16 15:20 ` H. Peter Anvin
2007-11-16 22:15 ` Sam Ravnborg
2007-11-16 22:58 ` H. Peter Anvin
2007-11-17 7:57 ` Sam Ravnborg
2007-11-17 10:16 ` [PATCH] x86: fix UTS_MACHINE to be "i386" for 32-bit build and "x86_64" for 64-bit build Andreas Herrmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071119093437.GA5104@devil \
--to=aherrman@arcor.de \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=sam@ravnborg.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.