All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Dooks <ben-linux@fluff.org>
To: netdev@vger.kernel.org
Cc: vince@simtec.co.uk, Ben Dooks <ben-linux@fluff.org>
Subject: [patch 21/22] NET: DM9000: Update retry count whilst identifying chip
Date: Mon, 19 Nov 2007 20:39:31 +0000	[thread overview]
Message-ID: <20071119204016.313770872@fluff.org> (raw)
In-Reply-To: 20071119203910.687238131@fluff.org

[-- Attachment #1: simtec/simtec-drivers-net-dm9000-id-retry.patch --]
[-- Type: text/plain, Size: 959 bytes --]

Reading the ID register does not always return the correct ID
from the device, so we retry several times to see if we get
a correct value.

These failures seem to be excaserbated by the speed of the
access to the chip (possibly time between issuing the address
and then the data cycle).

Signed-off-by: Ben Dooks <ben-linux@fluff.org>

Index: linux-2.6.23-quilt3/drivers/net/dm9000.c
===================================================================
--- linux-2.6.23-quilt3.orig/drivers/net/dm9000.c
+++ linux-2.6.23-quilt3/drivers/net/dm9000.c
@@ -652,7 +652,7 @@ dm9000_probe(struct platform_device *pde
 	dm9000_reset(db);
 
 	/* try two times, DM9000 sometimes gets the first read wrong */
-	for (i = 0; i < 2; i++) {
+	for (i = 0; i < 8; i++) {
 		id_val  = ior(db, DM9000_VIDL);
 		id_val |= (u32)ior(db, DM9000_VIDH) << 8;
 		id_val |= (u32)ior(db, DM9000_PIDL) << 16;

-- 
Ben (ben@fluff.org, http://www.fluff.org/)

  'a smiley only costs 4 bytes'

  parent reply	other threads:[~2007-11-19 21:14 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-19 20:39 [patch 00/22] DM9000 updates for 2.6.25 Ben Dooks
2007-11-19 20:39 ` [patch 01/22] NET: DM9000 use dev_xxx() instead of printk for output Ben Dooks
2007-11-24  1:35   ` Jeff Garzik
2007-11-19 20:39 ` [patch 02/22] NET: DM9000 update debugging macros to use debug level Ben Dooks
2007-11-24  1:36   ` Jeff Garzik
2007-11-19 20:39 ` [patch 03/22] NET: DM9000: Pass IRQ flags via platform data Ben Dooks
2007-11-24  1:36   ` Jeff Garzik
2007-11-19 20:39 ` [patch 04/22] NET: DM9000: Add initial ethtool support Ben Dooks
2007-11-24  1:38   ` Jeff Garzik
2007-11-19 20:39 ` [patch 05/22] NET: DM9000: Do not sleep with spinlock and IRQs held Ben Dooks
2007-11-24  1:38   ` Jeff Garzik
2007-11-19 20:39 ` [patch 06/22] NET: DM9000: Use kthread to probe MII status when device open Ben Dooks
2007-11-20  7:46   ` Christoph Hellwig
2007-11-20 10:13     ` Ben Dooks
2007-11-24  1:38   ` Jeff Garzik
2007-12-07 18:33     ` Ben Dooks
2007-11-19 20:39 ` [patch 07/22] NET: DM9000: Use msleep() instead of udelay() Ben Dooks
2007-11-24  1:39   ` Jeff Garzik
2007-12-07 15:42     ` Ben Dooks
2007-11-19 20:39 ` [patch 08/22] NET: DM9000: Remove barely used SROM array read Ben Dooks
2007-11-19 20:39 ` [patch 09/22] NET: DM9000: Add mutex to protect access Ben Dooks
2007-11-19 20:39 ` [patch 10/22] NET: DM9000: Add ethtool support for reading and writing EEPROM Ben Dooks
2007-11-19 20:39 ` [patch 11/22] NET: DM9000: Add ethtool control of msg_enable value Ben Dooks
2007-11-19 20:39 ` [patch 12/22] NET: DM9000: Remove EEPROM initialisation code Ben Dooks
2007-11-19 20:39 ` [patch 13/22] NET: DM9000: Ensure spinlock held whilst accessing EEPROM registers Ben Dooks
2007-11-19 20:39 ` [patch 14/22] NET: DM9000: Remove unnecessary changelog in header comment Ben Dooks
2007-11-24  1:41   ` Jeff Garzik
2007-11-19 20:39 ` [patch 15/22] NET: DM9000: Use netif_msg to enable debugging options Ben Dooks
2007-11-24  1:42   ` Jeff Garzik
2007-11-19 20:39 ` [patch 16/22] NET: DM9000: Fix delays used by EEPROM read and write Ben Dooks
2007-11-19 20:39 ` [patch 17/22] NET: DM9000: Remove cal_CRC() and use ether_crc_le instead Ben Dooks
2007-11-19 20:39 ` [patch 18/22] NET: DM9000: Remove redudant use of "& 0xff" Ben Dooks
2007-11-19 20:39 ` [patch 19/22] NET: DM9000: Add platform flag for no attached EEPROM Ben Dooks
2007-11-19 20:39 ` [patch 20/22] NET: DM9000: Add support for MII ioctl() calls Ben Dooks
2007-11-19 20:39 ` Ben Dooks [this message]
2007-11-19 20:39 ` [patch 22/22] NET: DM9000: Show the MAC address source after printing MAC Ben Dooks
2007-11-24  1:43   ` Jeff Garzik
2007-12-07 18:30     ` Ben Dooks
2007-11-19 23:04 ` [patch 00/22] DM9000 updates for 2.6.25 Stephen Hemminger
2007-11-20 10:13   ` Ben Dooks
2007-11-20 17:33 ` Ben Dooks

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071119204016.313770872@fluff.org \
    --to=ben-linux@fluff.org \
    --cc=netdev@vger.kernel.org \
    --cc=vince@simtec.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.