Re: mm snapshot broken-out-2007-11-20-01-45.tar.gz uploaded

[Paul Moore <paul.moore@hp.com>]

On Tuesday 20 November 2007 3:48:44 pm Paul Moore wrote:
> On Tuesday 20 November 2007 3:34:24 pm Kamalesh Babulal wrote:
> > Hi Andrew,
> >
> > The kernel build fails, in selinux with following error
> >
> >   CHK     include/linux/compile.h
> >   UPD     include/linux/compile.h
> >   CC      init/version.o
> >   LD      init/built-in.o
> >   LD      .tmp_vmlinux1
> > security/built-in.o(.toc1+0x928): undefined reference to
> > `selinux_xfrm_refcount' make: *** [.tmp_vmlinux1] Error 1
> > 11/20/2007-14:42:08 Build the kernel. Failed rc = 2
> > 11/20/2007-14:42:08 build: Building kernel... Failed rc = 1
> >
> > The patch causing this error is git-lblnet.patch, where in the
> > selinux_xfrm_enabled() is called from security/selinux/hooks.c, depends
> > on the extern atomic_tselinux_xfrm_refcount.
>
> The problem appears to be that the selinux_xfrm_refcount functionality is
> not properly protected by CONFIG_SECURITY_NETWORK_XFRM.  I'm fixing that
> now.

I've fixed the problem in the git tree below, meaning I just did a quick 
compile without defining CONFIG_SECURITY_NETWORK_XFRM and everything appeared 
to link correctly.  I haven't had a chance to try booting the fix yet because 
my test machine is a little slow compiling right now, but the fix was pretty 
trivial (simply move the extern and the inline function) so I don't expect 
any problems.

 * git://git.infradead.org/users/pcmoore/lblnet-2.6_testing

-- 
paul moore
linux security @ hp