From: Steven Rostedt <rostedt@goodmis.org>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Ingo Molnar <mingo@elte.hu>,
Gregory Haskins <ghaskins@novell.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Christoph Lameter <clameter@sgi.com>,
Steven Rostedt <srostedt@redhat.com>
Subject: [PATCH v4 04/20] RT overloaded runqueues accounting
Date: Tue, 20 Nov 2007 20:00:58 -0500 [thread overview]
Message-ID: <20071121011249.493691409@goodmis.org> (raw)
In-Reply-To: 20071121010054.663842380@goodmis.org
[-- Attachment #1: rt-overload.patch --]
[-- Type: text/plain, Size: 2060 bytes --]
This patch adds an RT overload accounting system. When a runqueue has
more than one RT task queued, it is marked as overloaded. That is that it
is a candidate to have RT tasks pulled from it.
Signed-off-by: Steven Rostedt <srostedt@redhat.com>
---
kernel/sched_rt.c | 36 ++++++++++++++++++++++++++++++++++++
1 file changed, 36 insertions(+)
Index: linux-compile.git/kernel/sched_rt.c
===================================================================
--- linux-compile.git.orig/kernel/sched_rt.c 2007-11-20 19:52:56.000000000 -0500
+++ linux-compile.git/kernel/sched_rt.c 2007-11-20 19:52:57.000000000 -0500
@@ -3,6 +3,38 @@
* policies)
*/
+#ifdef CONFIG_SMP
+static cpumask_t rt_overload_mask;
+static atomic_t rto_count;
+static inline int rt_overloaded(void)
+{
+ return atomic_read(&rto_count);
+}
+static inline cpumask_t *rt_overload(void)
+{
+ return &rt_overload_mask;
+}
+static inline void rt_set_overload(struct rq *rq)
+{
+ cpu_set(rq->cpu, rt_overload_mask);
+ /*
+ * Make sure the mask is visible before we set
+ * the overload count. That is checked to determine
+ * if we should look at the mask. It would be a shame
+ * if we looked at the mask, but the mask was not
+ * updated yet.
+ */
+ wmb();
+ atomic_inc(&rto_count);
+}
+static inline void rt_clear_overload(struct rq *rq)
+{
+ /* the order here really doesn't matter */
+ atomic_dec(&rto_count);
+ cpu_clear(rq->cpu, rt_overload_mask);
+}
+#endif /* CONFIG_SMP */
+
/*
* Update the current task's runtime statistics. Skip current tasks that
* are not in our scheduling class.
@@ -32,6 +64,8 @@ static inline void inc_rt_tasks(struct t
#ifdef CONFIG_SMP
if (p->prio < rq->rt.highest_prio)
rq->rt.highest_prio = p->prio;
+ if (rq->rt.rt_nr_running > 1)
+ rt_set_overload(rq);
#endif /* CONFIG_SMP */
}
@@ -53,6 +87,8 @@ static inline void dec_rt_tasks(struct t
} /* otherwise leave rq->highest prio alone */
} else
rq->rt.highest_prio = MAX_RT_PRIO;
+ if (rq->rt.rt_nr_running < 2)
+ rt_clear_overload(rq);
#endif /* CONFIG_SMP */
}
--
next prev parent reply other threads:[~2007-11-21 1:14 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-21 1:00 [PATCH v4 00/20] New RT Balancing version 4 Steven Rostedt
2007-11-21 1:00 ` [PATCH v4 01/20] Add rt_nr_running accounting Steven Rostedt
2007-11-21 1:00 ` [PATCH v4 02/20] track highest prio queued on runqueue Steven Rostedt
2007-11-21 1:00 ` [PATCH v4 03/20] push RT tasks Steven Rostedt
2007-11-21 1:00 ` Steven Rostedt [this message]
2007-11-21 1:00 ` [PATCH v4 05/20] pull " Steven Rostedt
2007-11-21 1:01 ` [PATCH v4 06/20] wake up balance RT Steven Rostedt
2007-11-21 1:01 ` [PATCH v4 07/20] disable CFS RT load balancing Steven Rostedt
2007-11-21 1:01 ` [PATCH v4 08/20] Cache cpus_allowed weight for optimizing migration Steven Rostedt
2007-11-21 1:01 ` [PATCH v4 09/20] RT: Consistency cleanup for this_rq usage Steven Rostedt
2007-11-21 1:01 ` [PATCH v4 10/20] RT: Remove some CFS specific code from the wakeup path of RT tasks Steven Rostedt
2007-11-21 1:01 ` [PATCH v4 11/20] RT: Break out the search function Steven Rostedt
2007-11-21 1:01 ` [PATCH v4 12/20] RT: Allow current_cpu to be included in search Steven Rostedt
2007-11-21 1:01 ` [PATCH v4 13/20] RT: Pre-route RT tasks on wakeup Steven Rostedt
2007-11-21 1:01 ` [PATCH v4 14/20] RT: Optimize our cpu selection based on topology Steven Rostedt
2007-11-21 1:01 ` [PATCH v4 15/20] RT: Optimize rebalancing Steven Rostedt
2007-11-21 1:01 ` [PATCH v4 16/20] Avoid overload Steven Rostedt
2007-11-21 1:01 ` [PATCH v4 17/20] RT: restore the migratable conditional Steven Rostedt
2007-11-21 1:01 ` [PATCH v4 18/20] Optimize cpu search with hamming weight Steven Rostedt
2007-11-21 1:01 ` [PATCH v4 19/20] Optimize out cpu_clears Steven Rostedt
2007-11-21 2:10 ` Steven Rostedt
2007-11-21 3:10 ` [PATCH] Fix optimized search Gregory Haskins
2007-11-21 4:15 ` Steven Rostedt
2007-11-21 4:26 ` Steven Rostedt
2007-11-21 5:14 ` Gregory Haskins
2007-11-21 1:01 ` [PATCH v4 20/20] balance RT tasks no new wake up Steven Rostedt
2007-11-21 4:44 ` [PATCH 0/4] more RT balancing enhancements Gregory Haskins
2007-11-21 4:44 ` [PATCH 1/4] Fix optimized search Gregory Haskins
2007-11-21 4:44 ` [PATCH 2/4] RT: Add sched-domain roots Gregory Haskins
2007-11-21 4:44 ` [PATCH 3/4] RT: Only balance our RT tasks within our root-domain Gregory Haskins
2007-11-21 4:44 ` [PATCH 4/4] RT: Use a 2-d bitmap for searching lowest-pri CPU Gregory Haskins
2007-11-21 19:51 ` [PATCH 0/4] more RT balancing enhancements v6a Gregory Haskins
2007-11-21 19:52 ` [PATCH 1/4] SCHED: Add sched-domain roots Gregory Haskins
2007-11-21 19:52 ` [PATCH 2/4] SCHED: Track online cpus in the root-domain Gregory Haskins
2007-11-21 19:52 ` [PATCH 3/4] SCHED: Only balance our RT tasks within our root-domain Gregory Haskins
2007-11-21 19:52 ` [PATCH 4/4] SCHED: Use a 2-d bitmap for searching lowest-pri CPU Gregory Haskins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071121011249.493691409@goodmis.org \
--to=rostedt@goodmis.org \
--cc=a.p.zijlstra@chello.nl \
--cc=clameter@sgi.com \
--cc=ghaskins@novell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=srostedt@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.