Re: Test tree patch inventory - update: 3rd batch

[Arnaldo Carvalho de Melo <acme@ghostprotocols.net>]

Em Wed, Nov 21, 2007 at 02:07:43PM +0000, Gerrit Renker escreveu:
> | > 7. Miscellaneous DCCP updates
> | > -----------------------------
> <snip>
> | > 	[DCCP]: Promote CCID2 as default CCID
> | 
> | Applied to simplify things for now, but I still think that for some
> | setups it may be interesting to allow CCID2 not to be built. 
> | 
> Yes, there is room to revise this for something better later on. I think
> this is much similar to the "use Reno or Cubic as default" in TCP, and 
> maybe one could use a similar Kconfig menu as it is currently done for
> the TCP modules.
>   
> | > 
> | > 8. The Feature-Negotiation patch set
> | > ------------------------------------
> | > The set splits into several smaller (self-contained) blocks, all documented in this section.
> | > The first block is distinct from feature negotiation, it only concerns request sockets:
> | > 
> | > 	[DCCP]: Allow to parse options on Request Sockets
> | 
> | This one can be folded with the next, I guess, since its only use of
> | the newly introduce dreq on dccp_parse_options is to test against NULL,
> | but that could be achieved by checking the packet type.
> | 
> | > 	[DCCP]: Add (missing) option parsing to request_sock processing
> Yes this is a tiny one. The first patch introduces the general code, the
> second is separate just because it adds the newly updated
> dccp_parse_options() to dccp_check_req(). 

OK, will do, just trying to be more informative about how I think its
correct so that in the future we do further fine tuning on how to
present patches.

You're doing well and has showed great patience, keep it up!

- Arnaldo