From: Aurelien Jarno <aurelien@aurel32.net>
To: qemu-devel@nongnu.org
Cc: paul@nowt.org
Subject: Re: [Qemu-devel] qemu fpu/softfloat-specialize.h fpu/softfloat.c...
Date: Wed, 21 Nov 2007 16:10:11 +0100 [thread overview]
Message-ID: <20071121151011.GD23909@hall.aurel32.net> (raw)
In-Reply-To: <47440B0D.1050601@aurel32.net>
On Wed, Nov 21, 2007 at 11:40:13AM +0100, Aurelien Jarno wrote:
> Aurelien Jarno a écrit :
> > Blue Swirl a écrit :
> >> On 11/18/07, Paul Brook <paul@nowt.org> wrote:
> >>> CVSROOT: /sources/qemu
> >>> Module name: qemu
> >>> Changes by: Paul Brook <pbrook> 07/11/18 14:33:24
> >>>
> >>> Modified files:
> >>> fpu : softfloat-specialize.h softfloat.c softfloat.h
> >>> target-arm/nwfpe: double_cpdo.c single_cpdo.c
> >>> target-m68k : helper.c op.c
> >>> target-mips : op_helper.c
> >>>
> >>> Log message:
> >>> Add strict checking mode for softfp code.
> >> This commit has broken sparc-softmmu, for example Aurora 1.0 normally prints:
> >> Running anaconda - please wait...
> >
> > There are also FPU regressions for mips-softmmu, but I haven't found
> > time to find the commit that has broken it, I just know it has been
> > broken over the week-end.
> >
> > More later...
>
> I am now able to confirm this very same commit has also broken the FPU
> on mips-softmmu, but I still don't know what is wrong in this commit.
>
Ok the problem comes from bad copy&paste. Please find a patch below that
fixes the problem on MIPS.
Index: fpu/softfloat.c
===================================================================
RCS file: /sources/qemu/qemu/fpu/softfloat.c,v
retrieving revision 1.8
diff -u -d -p -r1.8 softfloat.c
--- fpu/softfloat.c 18 Nov 2007 14:33:23 -0000 1.8
+++ fpu/softfloat.c 21 Nov 2007 15:06:19 -0000
@@ -3012,7 +3012,7 @@ int float64_eq( float64 a, float64 b STA
return 0;
}
av = float64_val(a);
- bv = float64_val(a);
+ bv = float64_val(b);
return ( av == bv ) || ( (bits64) ( ( av | bv )<<1 ) == 0 );
}
@@ -3038,7 +3038,7 @@ int float64_le( float64 a, float64 b STA
aSign = extractFloat64Sign( a );
bSign = extractFloat64Sign( b );
av = float64_val(a);
- bv = float64_val(a);
+ bv = float64_val(b);
if ( aSign != bSign ) return aSign || ( (bits64) ( ( av | bv )<<1 ) == 0 );
return ( av == bv ) || ( aSign ^ ( av < bv ) );
@@ -3064,7 +3064,7 @@ int float64_lt( float64 a, float64 b STA
aSign = extractFloat64Sign( a );
bSign = extractFloat64Sign( b );
av = float64_val(a);
- bv = float64_val(a);
+ bv = float64_val(b);
if ( aSign != bSign ) return aSign && ( (bits64) ( ( av | bv )<<1 ) != 0 );
return ( av != bv ) && ( aSign ^ ( av < bv ) );
@@ -3088,7 +3088,7 @@ int float64_eq_signaling( float64 a, flo
return 0;
}
av = float64_val(a);
- bv = float64_val(a);
+ bv = float64_val(b);
return ( av == bv ) || ( (bits64) ( ( av | bv )<<1 ) == 0 );
}
@@ -3116,7 +3116,7 @@ int float64_le_quiet( float64 a, float64
aSign = extractFloat64Sign( a );
bSign = extractFloat64Sign( b );
av = float64_val(a);
- bv = float64_val(a);
+ bv = float64_val(b);
if ( aSign != bSign ) return aSign || ( (bits64) ( ( av | bv )<<1 ) == 0 );
return ( av == bv ) || ( aSign ^ ( av < bv ) );
@@ -3145,7 +3145,7 @@ int float64_lt_quiet( float64 a, float64
aSign = extractFloat64Sign( a );
bSign = extractFloat64Sign( b );
av = float64_val(a);
- bv = float64_val(a);
+ bv = float64_val(b);
if ( aSign != bSign ) return aSign && ( (bits64) ( ( av | bv )<<1 ) != 0 );
return ( av != bv ) && ( aSign ^ ( av < bv ) );
--
.''`. Aurelien Jarno | GPG: 1024D/F1BCDB73
: :' : Debian developer | Electrical Engineer
`. `' aurel32@debian.org | aurelien@aurel32.net
`- people.debian.org/~aurel32 | www.aurel32.net
next prev parent reply other threads:[~2007-11-21 15:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-18 14:33 [Qemu-devel] qemu fpu/softfloat-specialize.h fpu/softfloat.c Paul Brook
2007-11-20 20:17 ` Blue Swirl
2007-11-20 20:42 ` Paul Brook
2007-11-21 8:51 ` Aurelien Jarno
2007-11-21 10:40 ` Aurelien Jarno
2007-11-21 15:10 ` Aurelien Jarno [this message]
2007-11-21 15:32 ` Paul Brook
2007-11-21 15:55 ` Eduardo Felipe
2007-11-21 18:58 ` Blue Swirl
2007-11-22 0:48 ` Thiemo Seufer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071121151011.GD23909@hall.aurel32.net \
--to=aurelien@aurel32.net \
--cc=paul@nowt.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.