All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: David Chinner <dgc@sgi.com>
Cc: xfs-dev <xfs-dev@sgi.com>, xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH,RFC] Factor some btree code....
Date: Wed, 21 Nov 2007 15:20:06 +0000	[thread overview]
Message-ID: <20071121152006.GD8454@infradead.org> (raw)
In-Reply-To: <20071106091836.GV995458@sgi.com>


I like this.  But I think a single set of xfs_btree_ops would be a lot
more readable.  Also I'm not sure we actually need all these ops, e.g.
instead of .buf_to_block we could always just call XFS_BUF_PTR directly.

  reply	other threads:[~2007-11-21 15:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-06  9:18 [PATCH,RFC] Factor some btree code David Chinner
2007-11-21 15:20 ` Christoph Hellwig [this message]
2007-11-21 21:42   ` David Chinner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071121152006.GD8454@infradead.org \
    --to=hch@infradead.org \
    --cc=dgc@sgi.com \
    --cc=xfs-dev@sgi.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.