From: Oleg Nesterov <oleg@tv-sign.ru>
To: Alexey Dobriyan <adobriyan@sw.ru>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Roland McGrath <roland@redhat.com>,
Scott James Remnant <scott@ubuntu.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -mm 1/2] ptrace_stop: fix the race with ptrace detach+attach
Date: Fri, 23 Nov 2007 13:54:57 +0300 [thread overview]
Message-ID: <20071123105457.GA93@tv-sign.ru> (raw)
In-Reply-To: <20071123102351.GD6240@localhost.sw.ru>
On 11/23, Alexey Dobriyan wrote:
>
> On Thu, Nov 22, 2007 at 07:14:59PM +0300, Oleg Nesterov wrote:
> > If the tracer went away (may_ptrace_stop() failed), ptrace_stop() drops tasklist
> > and then changes the ->state from TASK_TRACED to TASK_RUNNING.
> >
> > This can fool another tracer which attaches to us in between. Change the ->state
> > under tasklist_lock to ensure that ptrace_check_attach() can't wrongly succeed.
>
> ptrace_check_attach? Both do read_lock -- can run in parallel,
Yep.
> so how can it help?
read_lock prevents ptrace_attach(), so the new tracer can't attach
and then do ptrace_check_attach().
Oleg.
next prev parent reply other threads:[~2007-11-23 10:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-22 16:14 [PATCH -mm 1/2] ptrace_stop: fix the race with ptrace detach+attach Oleg Nesterov
2007-11-23 10:23 ` Alexey Dobriyan
2007-11-23 10:54 ` Oleg Nesterov [this message]
2007-12-11 1:36 ` Roland McGrath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071123105457.GA93@tv-sign.ru \
--to=oleg@tv-sign.ru \
--cc=adobriyan@sw.ru \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=roland@redhat.com \
--cc=scott@ubuntu.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.