From mboxrd@z Thu Jan 1 00:00:00 1970 From: Samuel Thibault Subject: [PATCH] Fix non-optimized compilation of Xen's memcmp Date: Fri, 23 Nov 2007 17:54:14 +0000 Message-ID: <20071123175414.GA12424@implementation.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org Even when using __builtin_memcmp, gcc may emit external references to memcmp (when not optimizing for instance), so this #define does not always provide a completely suitable memcmp(). Signed-off-by: Samuel Thibault diff -r 0eae1f245c8d xen/include/asm-x86/string.h --- a/xen/include/asm-x86/string.h Fri Nov 23 17:41:00 2007 +0000 +++ b/xen/include/asm-x86/string.h Fri Nov 23 17:50:51 2007 +0000 @@ -109,7 +109,6 @@ void *__memcpy(void *t, const void *f, s #define __HAVE_ARCH_MEMMOVE extern void *memmove(void *dest, const void *src, size_t n); -#define __HAVE_ARCH_MEMCMP #define memcmp __builtin_memcmp static inline void *__memset_generic(void *s, char c, size_t count)