From mboxrd@z Thu Jan  1 00:00:00 1970
From: Samuel Thibault <samuel.thibault@eu.citrix.com>
Subject: [PATCH] [Mini-OS] Fix domain blocking race
Date: Fri, 23 Nov 2007 18:15:41 +0000
Message-ID: <20071123181541.GA12767@implementation.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <xen-devel-bounces@lists.xensource.com>
Content-Disposition: inline
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

A callback which wakes a thread may happen between the moment schedule()
gives hand to the idle thread and the latter blocks the domain.  Idle
hence needs to atomically check that no thread is running and block,
else awoken threads may have to wait up to 10 seconds.

Signed-off-by: Samuel Thibault <samuel.thibault@citrix.com>

diff -r dc9246357cdb extras/mini-os/sched.c
--- a/extras/mini-os/sched.c	Fri Nov 23 16:42:44 2007 +0000
+++ b/extras/mini-os/sched.c	Fri Nov 23 18:11:18 2007 +0000
@@ -216,12 +216,29 @@
 void idle_thread_fn(void *unused)
 {
     s_time_t until;
+    unsigned long flags;
+    struct list_head *iterator;
+    struct thread *next, *thread;
     for(;;)
     {
         schedule();
-        /* block until the next timeout expires, or for 10 secs, whichever comes first */
-        until = blocking_time();
-        block_domain(until);
+        next = NULL;
+        local_irq_save(flags);
+        list_for_each(iterator, &idle_thread->thread_list)
+        {
+            thread = list_entry(iterator, struct thread, thread_list);
+            if(is_runnable(thread)) 
+            {
+                next = thread;
+                break;
+            }
+        }
+        if (!next) {
+            /* block until the next timeout expires, or for 10 secs, whichever comes first */
+            until = blocking_time();
+            block_domain(until);
+        }
+        local_irq_restore(flags);
         wake_expired();
     }
 }