From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org, l_indien@magic.fr
Subject: Re: [Qemu-devel] qemu hw/ppc_oldworld.c target-ppc/cpu.h target-...
Date: Fri, 23 Nov 2007 19:10:21 +0000 [thread overview]
Message-ID: <200711231910.22296.paul@codesourcery.com> (raw)
In-Reply-To: <1195843374.24939.22.camel@jma4.dev.netgem.com>
> > The old code before the patch is obviously broken. It's mixing 64-bit
> > (ppc_gpr_t) and 32-bit (target_ulong) values.
>
> It seems you do not understand that what was done was correct. It's not
> mixing two different types. GPR are of ppc_gpr_t type and should be
> displayed this way.
> It's not garbage. On 64 bits hosts, the 64 bits GPR dump is correct. GPR
> _are 64 bits_ when compiling the ppcemb target and should be displayed
> as 64 bits value.
Really? Where exactly is the code that uses a 64-bit ppc_gpr_t ?
I don't see any evidence that the high bits of the value is ever used.
I see the SPE stuff that uses T0_64 et al, however this still uses stores the
value in the low 32 bits of the {gpr,gprth} pair.
Paul
next prev parent reply other threads:[~2007-11-23 19:10 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-23 17:33 [Qemu-devel] qemu hw/ppc_oldworld.c target-ppc/cpu.h target- Paul Brook
2007-11-23 17:51 ` Jocelyn Mayer
2007-11-23 18:22 ` Paul Brook
2007-11-23 18:42 ` Jocelyn Mayer
2007-11-23 18:46 ` Jocelyn Mayer
2007-11-23 19:10 ` Paul Brook [this message]
2007-11-23 19:19 ` Jocelyn Mayer
2007-11-23 20:08 ` Jocelyn Mayer
2007-11-23 21:36 ` Paul Brook
2007-11-23 22:05 ` J. Mayer
2007-11-23 22:23 ` Paul Brook
2007-11-23 23:36 ` Thiemo Seufer
2007-11-24 19:39 ` Fabrice Bellard
2007-11-23 23:36 ` J. Mayer
2007-11-24 0:18 ` Thiemo Seufer
2007-11-24 0:52 ` Paul Brook
2007-11-24 1:02 ` Julian Seward
2007-11-24 1:32 ` J. Mayer
2007-11-24 1:55 ` J. Mayer
-- strict thread matches above, loose matches on Subject: below --
2007-11-23 22:16 Jocelyn Mayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200711231910.22296.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=l_indien@magic.fr \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.