From: "Mark M. Hoffman" <mhoffman@lightlink.com>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH] hwmon: (lm90) Use generic i2c reads during
Date: Sun, 25 Nov 2007 21:28:56 +0000 [thread overview]
Message-ID: <20071125212856.GA7021@jupiter.solarsys.private> (raw)
In-Reply-To: <20071025000543.67dc6edb@hyperion.delvare>
Hi Jean:
* Jean Delvare <khali@linux-fr.org> [2007-11-25 21:58:21 +0100]:
> Oops, my patch was actually broken (misplaced parentheses). Here's an
> update, sorry.
>
> * * * * *
>
> As indirectly reported by Olof Johansson, the lm90 driver uses a
> custom i2c read function even during detection, at which point we
> don't know yet what device we're talking with. It would make more
> sense to only use the generic i2c read function at this point, so
> that we don't log irrelevant errors on misdetection.
>
> Signed-off-by: Jean Delvare <khali@linux-fr.org>
> ---
> drivers/hwmon/lm90.c | 24 ++++++++++++------------
> 1 file changed, 12 insertions(+), 12 deletions(-)
Yep, I missed that too. I've inserted this patch into hwmon-2.6.git/testing
in place of the previous one, thanks.
--
Mark M. Hoffman
mhoffman@lightlink.com
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
prev parent reply other threads:[~2007-11-25 21:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-24 22:05 [lm-sensors] [PATCH] hwmon: (lm90) Use generic i2c reads during Jean Delvare
2007-11-25 1:53 ` Mark M. Hoffman
2007-11-25 20:58 ` Jean Delvare
2007-11-25 21:28 ` Mark M. Hoffman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071125212856.GA7021@jupiter.solarsys.private \
--to=mhoffman@lightlink.com \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.