From: Andrew Morton <akpm@linux-foundation.org>
To: Udo van den Heuvel <udovdh@xs4all.nl>
Cc: linux-kernel@vger.kernel.org, Michael Buesch <mb@bu3sch.de>
Subject: Re: enable dual rng on VIA C7
Date: Sun, 25 Nov 2007 23:39:49 -0800 [thread overview]
Message-ID: <20071125233949.f64b2ecd.akpm@linux-foundation.org> (raw)
In-Reply-To: <47374EA4.1060009@xs4all.nl>
On Sun, 11 Nov 2007 19:49:08 +0100 Udo van den Heuvel <udovdh@xs4all.nl> wrote:
> Any reason why the second rng on the VIA C7 CPU is not enabled?
>
> Kind regards,
> Udo
>
>
> [via-rng.patch text/plain (634B)]
> --- old/drivers/char/hw_random/via-rng.c 2007-11-11 19:39:49.000000000 +0100
> +++ new/drivers/char/hw_random/via-rng.c 2007-11-11 19:40:41.000000000 +0100
> @@ -41,6 +41,7 @@
> VIA_STRFILT_ENABLE = (1 << 14),
> VIA_RAWBITS_ENABLE = (1 << 13),
> VIA_RNG_ENABLE = (1 << 6),
> + VIA_RNG_DUAL = (1 << 9),
> VIA_XSTORE_CNT_MASK = 0x0F,
>
> VIA_RNG_CHUNK_8 = 0x00, /* 64 rand bits, 64 stored bits */
> @@ -128,6 +129,7 @@
> lo &= ~(0x7f << VIA_STRFILT_CNT_SHIFT);
> lo &= ~VIA_XSTORE_CNT_MASK;
> lo &= ~(VIA_STRFILT_ENABLE | VIA_STRFILT_FAIL | VIA_RAWBITS_ENABLE);
> + lo |= VIA_RNG_DUAL;
> lo |= VIA_RNG_ENABLE;
>
> if (lo != old_lo)
>
Does the patch work?
It's missing a signed-off-by:, btw
next prev parent reply other threads:[~2007-11-26 7:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-11 18:49 enable dual rng on VIA C7 Udo van den Heuvel
2007-11-26 7:39 ` Andrew Morton [this message]
2007-11-26 17:02 ` Udo van den Heuvel
2007-11-26 18:58 ` Dave Jones
2007-11-27 16:08 ` Udo van den Heuvel
2007-11-27 18:50 ` Dave Jones
2007-11-27 19:01 ` Udo van den Heuvel
2007-11-27 20:51 ` Andrew Morton
2007-12-01 16:51 ` Udo van den Heuvel
2008-01-25 19:03 ` Udo van den Heuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071125233949.f64b2ecd.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mb@bu3sch.de \
--cc=udovdh@xs4all.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.