From: Andrew Morton <akpm@linux-foundation.org>
To: andrew.patterson@hp.com
Cc: linux-kernel@vger.kernel.org, linux-hotplug@vger.kernel.org
Subject: Re: Error returns not handled correctly by sysfs.c:subsys_attr_store()
Date: Mon, 26 Nov 2007 20:31:16 -0800 [thread overview]
Message-ID: <20071126203116.0c93cdb9.akpm@linux-foundation.org> (raw)
In-Reply-To: <1195683419.16019.225.camel@grinch>
On Wed, 21 Nov 2007 15:16:59 -0700 Andrew Patterson <andrew.patterson@hp.com> wrote:
> The buf in fs/sysfs.c:subsys_attr_store() does not seem to be updated
> correctly when returning a negative value (indicating that an error
> condition has occurred) is returned. If a negative value is returned,
> the next subsequent call to subsys_attr_store will have the contents of
> buf appended to the previous call.
subsys_attr_store() gets deleted by
http://www.kernel.org/pub/linux/kernel/people/gregkh/gregkh-2.6/gregkh-01-driver/kset-kill-subsys-attr.patch
So maybe we will soon accidentally fix whatever-this-is? Or maybe we will
faithfully maintain it.
next prev parent reply other threads:[~2007-11-27 4:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-21 22:16 Error returns not handled correctly by sysfs.c:subsys_attr_store() Andrew Patterson
2007-11-27 4:31 ` Andrew Morton [this message]
2007-11-27 5:33 ` Greg KH
2007-11-27 5:38 ` Tejun Heo
2007-11-28 7:42 ` Tejun Heo
2007-11-28 19:31 ` Andrew Patterson
2007-11-28 20:05 ` Greg KH
2007-11-29 1:07 ` Tejun Heo
2007-12-03 21:15 ` Andrew Patterson
2007-12-21 20:35 ` Greg KH
2008-01-03 23:51 ` Andrew Patterson
2008-01-04 0:07 ` Tejun Heo
2008-01-04 0:17 ` Andrew Patterson
2008-01-04 0:56 ` Andrew Patterson
2008-01-04 7:30 ` Andrey Borzenkov
2008-01-07 21:13 ` Andrew Patterson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071126203116.0c93cdb9.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=andrew.patterson@hp.com \
--cc=linux-hotplug@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.