All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Prakash Punnoor <prakash@punnoor.de>
Cc: "peerchen" <peerchen@gmail.com>,
	"linux-kernel" <linux-kernel@vger.kernel.org>,
	"pchen" <pchen@nvidia.com>, "acurrid" <acurrid@nvidia.com>
Subject: Re: [PATCH 1/2] msi: set 'En' bit of MSI Mapping Capability on HT platform
Date: Tue, 27 Nov 2007 00:00:08 -0800	[thread overview]
Message-ID: <20071127000008.1d4dc323.akpm@linux-foundation.org> (raw)
In-Reply-To: <200711251121.49585.prakash@punnoor.de>

On Sun, 25 Nov 2007 11:21:45 +0100 Prakash Punnoor <prakash@punnoor.de> wrote:

> Yay:

Sounds good.

> One thing I noticed in the patch:
> +		if (((bridge_dev = pci_find_slot(0, 0)) != NULL) &&
> 
> You rather want to use pci_get_bus_and_slot instead, as pci_find_slot is 
> deprecated.

yup.  I'll queue this to get it a bit of testing but won't send it to Greg,
in the expectation that an updated version will be prepared.

Please do feed the diff through scripts/checkpatch.pl too - there are a
large number of trivial coding-style glitches in there.


Also, your [patch 1/2] will break the build unless your [patch 2/2] is
applied.  This will break git bisection so please avoid it.  It is
appropriate to fold both these patches into a single one.

And please avoid sending multiple patches under the same title, as these
two were.

Thanks.

  reply	other threads:[~2007-11-27  8:00 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-25  3:21 [PATCH 1/2] msi: set 'En' bit of MSI Mapping Capability on HT platform peerchen
2007-11-25 10:21 ` Prakash Punnoor
2007-11-27  8:00   ` Andrew Morton [this message]
2007-11-26  9:43 ` Sébastien Dugué
2007-11-27  8:13 ` Andrew Morton
     [not found] <fa.o8FrHkCTygSL3HgQ8yHeTr2D3tI@ifi.uio.no>
2007-11-25 18:33 ` Robert Hancock
2007-11-26  4:01   ` Peer Chen
2007-11-26  5:14     ` Andy Currid

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071127000008.1d4dc323.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=acurrid@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pchen@nvidia.com \
    --cc=peerchen@gmail.com \
    --cc=prakash@punnoor.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.