From: Pavel Machek <pavel@ucw.cz>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: pm list <linux-pm@lists.linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/6] Suspend: Use common prefix in messages
Date: Tue, 27 Nov 2007 01:21:45 +0100 [thread overview]
Message-ID: <20071127002145.GD9759@elf.ucw.cz> (raw)
In-Reply-To: <200711270030.10561.rjw@sisk.pl>
Hi!
> From: Rafael J. Wysocki <rjw@sisk.pl>
>
> Make suspend messages start with one common prefix "PM: ".
>
> Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
I do not think I like the PREFIX idea (see other message).
> @@ -344,11 +344,12 @@ static int enter_state(suspend_state_t s
> if (!mutex_trylock(&pm_mutex))
> return -EBUSY;
>
> - printk("Syncing filesystems ... ");
> + printk(KERN_INFO PREFIX "Syncing filesystems ... ");
> sys_sync();
> - printk("done.\n");
> + printk(KERN_INFO "done.\n");
Plus this is wrong.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2007-11-27 0:21 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-26 23:25 [PATCH 0/6] Suspend and hibernation code cleanups Rafael J. Wysocki
2007-11-26 23:27 ` [PATCH 1/6] Suspend: Fix compilation warning for CONFIG_SUSPEND unset Rafael J. Wysocki
2007-11-26 23:27 ` Rafael J. Wysocki
2007-11-27 0:12 ` Pavel Machek
2007-11-27 0:12 ` Pavel Machek
2007-11-26 23:29 ` [PATCH 2/6] Hibernation: Move low level resume to disk.c Rafael J. Wysocki
2007-11-27 0:29 ` Pavel Machek
2007-11-27 16:06 ` Rafael J. Wysocki
2007-11-27 0:29 ` Pavel Machek
2007-11-26 23:29 ` Rafael J. Wysocki
2007-11-26 23:30 ` [PATCH 3/6] Suspend: Use common prefix in messages Rafael J. Wysocki
2007-11-27 0:21 ` Pavel Machek [this message]
2007-11-27 16:16 ` Rafael J. Wysocki
2007-11-27 0:21 ` Pavel Machek
2007-11-26 23:30 ` Rafael J. Wysocki
2007-11-26 23:31 ` [PATCH 4/6] Suspend: Fix comment in main.c Rafael J. Wysocki
2007-11-27 0:14 ` Pavel Machek
2007-11-27 0:14 ` Pavel Machek
2007-11-26 23:31 ` Rafael J. Wysocki
2007-11-26 23:32 ` [PATCH 5/6] Hibernation: Use common prefix in messages Rafael J. Wysocki
2007-11-26 23:32 ` Rafael J. Wysocki
2007-11-27 0:20 ` Pavel Machek
2007-11-27 0:20 ` Pavel Machek
2007-11-26 23:33 ` [PATCH 6/6] Hibernation: Move extern definition to header file Rafael J. Wysocki
2007-11-26 23:33 ` Rafael J. Wysocki
2007-11-27 0:23 ` Pavel Machek
2007-11-27 0:23 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071127002145.GD9759@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.