From: WANG Cong <xiyou.wangcong@gmail.com>
To: Richard Knutsson <ricknu-0@student.ltu.se>
Cc: mchehab@infradead.org, v4l-dvb-maintainer@linuxtv.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [VIDEO]: Complement va_start() with va_end().
Date: Tue, 27 Nov 2007 17:01:01 +0800 [thread overview]
Message-ID: <20071127090101.GA2626@hacking> (raw)
In-Reply-To: <20071127065410.4293.71568.sendpatchset@thinktank.campus.ltu.se>
On Tue, Nov 27, 2007 at 08:06:17AM +0100, Richard Knutsson wrote:
>Complement va_start() with va_end().
>
>Signed-off-by: Richard Knutsson <ricknu-0@student.ltu.se>
>---
>Compile-tested on i386 with allyesconfig and allmodconfig.
>
>
>diff --git a/drivers/media/video/saa5246a.c b/drivers/media/video/saa5246a.c
>index ad02329..996b494 100644
>--- a/drivers/media/video/saa5246a.c
>+++ b/drivers/media/video/saa5246a.c
>@@ -187,12 +187,14 @@ static int i2c_senddata(struct saa5246a_device *t, ...)
> {
> unsigned char buf[64];
> int v;
>- int ct=0;
>+ int ct = 0;
> va_list argp;
>- va_start(argp,t);
>+ va_start(argp, t);
Hi, Richard!
These are style fixes, and you did't mention this above. ;)
Thanks.
Cong
next prev parent reply other threads:[~2007-11-27 9:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-27 7:06 [PATCH] [VIDEO]: Complement va_start() with va_end() Richard Knutsson
2007-11-27 9:01 ` WANG Cong [this message]
2007-11-27 9:21 ` [PATCH] [VIDEO]: Complement va_start() with va_end() + style fixes Richard Knutsson
2007-11-27 9:52 ` Richard Knutsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071127090101.GA2626@hacking \
--to=xiyou.wangcong@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=ricknu-0@student.ltu.se \
--cc=v4l-dvb-maintainer@linuxtv.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.