From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean Delvare Date: Tue, 27 Nov 2007 11:18:48 +0000 Subject: Re: [lm-sensors] [PATCH] Driver for Winbond W83L786NG/NR Message-Id: <20071127121848.15f5579b@hyperion.delvare> List-Id: References: <1188522272.5885.8.camel@monet> In-Reply-To: <1188522272.5885.8.camel@monet> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: lm-sensors@vger.kernel.org Hi Kevin, On Mon, 26 Nov 2007 09:38:54 +0800, Kevin Lo wrote: > On Sun, 2007-11-25 at 13:39 +0100, Jean Delvare wrote: > > On Fri, 23 Nov 2007 09:31:52 +0800, Kevin Lo wrote: > > > Here is the revised patch which fixes the issues that you mentioned. > > > > > > Signed-off-by: Kevin Lo > > > > Dave, can you please test this new iteration of Kevin's driver and > > confirm that it works fine for you? > > > > The patch is here if you're not subscribed to the list: > > http://lists.lm-sensors.org/pipermail/lm-sensors/2007-November/021975.html > > > > Kevin, did you test your driver with lm-sensors 3.0.0? > > No, but I tested my patch with lm-sensors 2.10.5, it worked fine. I don't get it. For lm-sensors 2.10.5, you need chip-specific code for every new driver, and there's no such code for the W83L786NG yet. So I don't quite see how you could have tested it. Or do you have a patch for lm-sensors that adds support? If so, please post it so that it can be reviewed and applied. Anyway, lm-sensors 3.0.0 only supports the standard kernel interface, so it is a very interesting test to make sure that your driver implements the standard interface properly. Please give it a try. Thanks, -- Jean Delvare _______________________________________________ lm-sensors mailing list lm-sensors@lm-sensors.org http://lists.lm-sensors.org/mailman/listinfo/lm-sensors