All of lore.kernel.org
 help / color / mirror / Atom feed
From: mark gross <mgross@linux.intel.com>
To: lkml <linux-kernel@vger.kernel.org>
Cc: ak@linux.intel.com
Subject: [mgross@linux.intel.com: intel-iommu-PMEN-think-oh patch.]
Date: Tue, 27 Nov 2007 15:48:02 -0800	[thread overview]
Message-ID: <20071127234802.GB14134@linux.intel.com> (raw)

I forgot to cc the list.

--mgross

----- Forwarded message from mark gross <mgross@linux.intel.com> -----

Date: Tue, 27 Nov 2007 15:46:09 -0800
From: mark gross <mgross@linux.intel.com>
To: Andrew Morton <akpm@linux-foundation.org>
Reply-To: mgross@linux.intel.com
Subject: intel-iommu-PMEN-think-oh patch.

I screwed up with my earlier patch to enable the portected memroy.  The
macro IOMMU_WAIT, exits when the condition goes true.  Without this
patch the code will hang at boot and some ( all?) vtd enabled systems.


--mgross

Signed-off-by: mark gross <mgross@linux.intel.com>


Index: linux-2.6.24-rc2+/drivers/pci/intel-iommu.c
===================================================================
--- linux-2.6.24-rc2+.orig/drivers/pci/intel-iommu.c	2007-11-27 15:29:38.000000000 -0800
+++ linux-2.6.24-rc2+/drivers/pci/intel-iommu.c	2007-11-27 15:30:06.000000000 -0800
@@ -704,7 +704,7 @@
 
 	/* wait for the protected region status bit to clear */
 	IOMMU_WAIT_OP(iommu, DMAR_PMEN_REG,
-		readl, (pmen & DMA_PMEN_PRS), pmen);
+		readl, !(pmen & DMA_PMEN_PRS), pmen);
 
 	spin_unlock_irqrestore(&iommu->register_lock, flags);
 }

----- End forwarded message -----

                 reply	other threads:[~2007-11-27 23:47 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071127234802.GB14134@linux.intel.com \
    --to=mgross@linux.intel.com \
    --cc=ak@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.