All of lore.kernel.org
 help / color / mirror / Atom feed
From: Denys Vlasenko <vda.linux@googlemail.com>
To: Hugh Dickins <hugh@veritas.com>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -mm] printk trivial optimizations fix
Date: Wed, 28 Nov 2007 20:06:18 -0800	[thread overview]
Message-ID: <200711282006.18527.vda.linux@googlemail.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0711281900010.25292@blonde.wat.veritas.com>

On Wednesday 28 November 2007 11:02, Hugh Dickins wrote:
> mm's printk has been showing "%p" in abominable upper case recently:
> its trivial optimizations have changed the default from lower to upper,
> so the 'p' case needs to enforce lower explicitly.
>
> Signed-off-by: Hugh Dickins <hugh@veritas.com>
> ---
>
>  lib/vsprintf.c |    1 +
>  1 file changed, 1 insertion(+)
>
> --- 2.6.24-rc3-mm2/lib/vsprintf.c	2007-11-28 12:42:26.000000000 +0000
> +++ linux/lib/vsprintf.c	2007-11-28 17:01:20.000000000 +0000
> @@ -525,6 +525,7 @@ int vsnprintf(char *buf, size_t size, co
>  				continue;
>
>  			case 'p':
> +				flags |= SMALL;
>  				if (field_width == -1) {
>  					field_width = 2*sizeof(void *);
>  					flags |= ZEROPAD;

Thanks Hugh for catching this. My fault :(
--
vda

      reply	other threads:[~2007-11-29  4:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-28 19:02 [PATCH -mm] printk trivial optimizations fix Hugh Dickins
2007-11-29  4:06 ` Denys Vlasenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200711282006.18527.vda.linux@googlemail.com \
    --to=vda.linux@googlemail.com \
    --cc=akpm@linux-foundation.org \
    --cc=hugh@veritas.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.