From: Tony Lindgren <tony@atomide.com>
To: Jarkko Nikula <jarkko.nikula@nokia.com>
Cc: linux-omap-open-source@linux.omap.com
Subject: Re: [patch 2.6.24-rc3-omap1] i2c init section fixes
Date: Wed, 28 Nov 2007 12:48:45 -0800 [thread overview]
Message-ID: <20071128204844.GX11825@atomide.com> (raw)
In-Reply-To: <20071126105400.0133e18f.jarkko.nikula@nokia.com>
* Jarkko Nikula <jarkko.nikula@nokia.com> [071126 00:59]:
> On Fri, 23 Nov 2007 23:20:05 -0800
> "ext David Brownell" <david-b@pacbell.net> wrote:
>
> > Fix init section warnings in the new i2c init code. It's
> > wrong to call "__init" functions from non-__init ones.
> >
> > Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
> >
> > --- a/arch/arm/plat-omap/i2c.c
> > +++ b/arch/arm/plat-omap/i2c.c
> >
> Since i2c_register_board_info is defined with __init, we have to define
> functions here with __init as well.
>
> Acked-by: Jarkko Nikula <jarkko.nikula@nokia.com>
>
> ---
>
> How do I enable that warning since I don't see it now? I remember that I
> saw some timer related __init warnings some time ago. I'm using
> "gcc version 3.4.4 (release) (CodeSourcery ARM 2005q3-2)".
Pushing today.
Tony
prev parent reply other threads:[~2007-11-28 20:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-24 7:20 [patch 2.6.24-rc3-omap1] i2c init section fixes David Brownell
2007-11-26 8:54 ` Jarkko Nikula
2007-11-28 20:48 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071128204844.GX11825@atomide.com \
--to=tony@atomide.com \
--cc=jarkko.nikula@nokia.com \
--cc=linux-omap-open-source@linux.omap.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.