From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Chinner Subject: Re: [patch 13/19] Use page_cache_xxx in fs/splice.c Date: Thu, 29 Nov 2007 14:40:11 +1100 Message-ID: <20071129034011.GU119954183@sgi.com> References: <20071129011052.866354847@sgi.com> <20071129011147.323915994@sgi.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, Christoph Hellwig , Mel Gorman , William Lee Irwin III , David Chinner , Jens Axboe , Badari Pulavarty , Maxim Levitsky , Fengguang Wu , swin wang , totty.lu@gmail.com, hugh@veritas.com, joern@lazybastard.org To: Christoph Lameter Return-path: Received: from netops-testserver-3-out.sgi.com ([192.48.171.28]:44589 "EHLO relay.sgi.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755590AbXK2Dkj (ORCPT ); Wed, 28 Nov 2007 22:40:39 -0500 Content-Disposition: inline In-Reply-To: <20071129011147.323915994@sgi.com> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Wed, Nov 28, 2007 at 05:11:05PM -0800, Christoph Lameter wrote: > @@ -453,7 +454,7 @@ fill_it: > */ > while (page_nr < nr_pages) > page_cache_release(pages[page_nr++]); > - in->f_ra.prev_pos = (loff_t)index << PAGE_CACHE_SHIFT; > + in->f_ra.prev_pos = page_cache_index(mapping, index); in->f_ra.prev_pos = page_cache_pos(mapping, index, 0); Cheers, Dave. -- Dave Chinner Principal Engineer SGI Australian Software Group From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Thu, 29 Nov 2007 14:40:11 +1100 From: David Chinner Subject: Re: [patch 13/19] Use page_cache_xxx in fs/splice.c Message-ID: <20071129034011.GU119954183@sgi.com> References: <20071129011052.866354847@sgi.com> <20071129011147.323915994@sgi.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20071129011147.323915994@sgi.com> Sender: owner-linux-mm@kvack.org Return-Path: To: Christoph Lameter Cc: akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, Christoph Hellwig , Mel Gorman , William Lee Irwin III , David Chinner , Jens Axboe , Badari Pulavarty , Maxim Levitsky , Fengguang Wu , swin wang , totty.lu@gmail.com, hugh@veritas.com, joern@lazybastard.org List-ID: On Wed, Nov 28, 2007 at 05:11:05PM -0800, Christoph Lameter wrote: > @@ -453,7 +454,7 @@ fill_it: > */ > while (page_nr < nr_pages) > page_cache_release(pages[page_nr++]); > - in->f_ra.prev_pos = (loff_t)index << PAGE_CACHE_SHIFT; > + in->f_ra.prev_pos = page_cache_index(mapping, index); in->f_ra.prev_pos = page_cache_pos(mapping, index, 0); Cheers, Dave. -- Dave Chinner Principal Engineer SGI Australian Software Group -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org