From: Eric Wong <normalperson@yhbt.net>
To: Gustaf Hendeby <hendeby@isy.liu.se>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH] git-svn now reads settings even if called in subdirectory
Date: Wed, 28 Nov 2007 23:41:32 -0800 [thread overview]
Message-ID: <20071129074132.GA32277@soma> (raw)
In-Reply-To: <1195912076-3903-1-git-send-email-hendeby@isy.liu.se>
Gustaf Hendeby <hendeby@isy.liu.se> wrote:
> Previously, git-svn first read the .git/config file for settings as if
> current working directory was the repository top-directory, and after
> that made sure to cd into top-directory. The result was a silent
> failur to read configuration settings. This patch changes the order
> these two things are done.
>
> Signed-off-by: Gustaf Hendeby <hendeby@isy.liu.se>
>
> ---
>
> This fix seems a bit too obvious, which makes me think I missed
> something conceptual here. However, the patch passes "make test" and
> "make full-svn-test", and the problems I had with the svn.authorsfile
> setting not being honored while fetching from a subdirectory are gone.
Thanks Gustaf,
Seems right to me (note: I never use the authors file feature myself).
Acked-by: Eric Wong <normalperson@yhbt.net>
--
Eric Wong
prev parent reply other threads:[~2007-11-29 7:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-24 13:47 [PATCH] git-svn now reads settings even if called in subdirectory Gustaf Hendeby
2007-11-29 7:41 ` Eric Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071129074132.GA32277@soma \
--to=normalperson@yhbt.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=hendeby@isy.liu.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.