From: Paul Mundt <lethal@linux-sh.org>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH]: sh4 delay slot code update
Date: Thu, 29 Nov 2007 18:30:41 +0900 [thread overview]
Message-ID: <20071129093041.GA3030@linux-sh.org> (raw)
In-Reply-To: <aec7e5c30711290118i3ff8b13bpde12b695c90ece60@mail.gmail.com>
On Thu, Nov 29, 2007 at 06:18:32PM +0900, Magnus Damm wrote:
> On Nov 29, 2007 2:55 PM, Paul Mundt <lethal@linux-sh.org> wrote:
> > The T-state check for bt/bf happens _prior_ to execution of the delay
> > slot instruction, while any delay-slot resident T-bit modifier is
> > executed by the time we enter the branch. I don't know if your code
> > handles that or not, but figured it's probably good to make that
> > explicit. T-bit modifiers are always a bit hairy..
>
> Yeah, the T flag is indeed a bit hairy. The patch should handle the T
> bit exactly as you describe it. As part of the bt/bf instruction the T
> flag is evaluated and if true the the DELAY_SLOT_TRUE bit is set. This
> bit is later used to decide if we should jump or not after the delay
> slot instruction.
>
Ok, I have no objection to these changes then.
prev parent reply other threads:[~2007-11-29 9:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-28 9:54 [Qemu-devel] [PATCH]: sh4 delay slot code update Magnus Damm
2007-11-28 12:49 ` Paul Mundt
2007-11-29 5:43 ` Magnus Damm
2007-11-29 5:55 ` Paul Mundt
2007-11-29 9:18 ` Magnus Damm
2007-11-29 9:30 ` Paul Mundt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071129093041.GA3030@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.