From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] PPC440: HCU5-board: make vxWorks boot
Date: Fri, 30 Nov 2007 21:01:09 +0100 [thread overview]
Message-ID: <200711302101.09975.sr@denx.de> (raw)
In-Reply-To: <200711301503.14890.niklausgiger@gmx.ch>
On Friday 30 November 2007, Niklaus Giger wrote:
> Signed-off-by: Niklaus Giger <niklaus.giger@netstal.com>
> ---
> board/netstal/hcu5/init.S | 63
> ++++++++++++++++++++++++++++++++-------------
> 1 files changed, 45 insertions(+), 18 deletions(-)
Two small problems with this patch:
a) The patch is line wrapped.
b) For my taste, this mail subject alone does not describe these
changes of this patch correctly. Please add a few line of
patch description, so that we really "understand" why this
patch is needed and why it helps booting VxWorks
Thanks.
Best regards,
Stefan
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================
prev parent reply other threads:[~2007-11-30 20:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-30 14:03 [U-Boot-Users] [PATCH] PPC440: HCU5-board: make vxWorks boot Niklaus Giger
2007-11-30 20:01 ` Stefan Roese [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200711302101.09975.sr@denx.de \
--to=sr@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.