Re: [PATCH] Some grammatical and whitespace cleanups in init.h.

[Matthew Wilcox <matthew@wil.cx>]

On Fri, Nov 30, 2007 at 04:01:56PM -0500, Robert P. J. Day wrote:
> On Fri, 30 Nov 2007, Matthew Wilcox wrote:
> 
> > On Fri, Nov 30, 2007 at 02:24:57PM -0500, Robert P. J. Day wrote:
> > > -/* These macros are used to mark some functions or
> > > - * initialized data (doesn't apply to uninitialized data)
> > > - * as `initialization' functions. The kernel can take this
> > > - * as hint that the function is used only during the initialization
> > > - * phase and free up used memory resources after
> > > +/* These macros are used to mark functions and initialized
> > > + * data as 'initialization' objects, which tells the kernel that
> > > + * they are used only during the initialization phase and can be
> > > + * freed afterwards to recover memory.
> >
> > If you're going to get rid of 'some', then you need to change 'are' to
> > 'may be' or 'can be'.
> 
> i'm sorry, i don't see a problem here.  that replacement text looks
> perfectly unambiguous.  how do you think it might be misinterpreted?

It implies that all functions have to be marked as __init, which is
plainly not true.

-- 
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."