Re: [PATCH] 1616(M) cardbus improvements

[Ctirad Fertr <c.fertr@gmail.com>]

Dne Tuesday 27 of November 2007 17:43:05 jste napsal(a):
> The changes look almost good to me.  But, if I understand correctly,
> the input source put isn't changed properly for EMU1616.

No, it's correct, because emu1010_input_dst[] structure is generic for 
all EMU PCI cards.

> The patch below is the revised version with bunch of coding style
> fixes (at the next time, try scripts/checkpatch.pl in linux kernel
> tree before submission).

I will do that next time. Thank you. 

> Let me know if it works for you.  I'll apply to ALSA tree after your
> confirmation.

I works very well :)

Unfortunatelly, now I found that driver (or host card) reload causes kernel 
ooops on 2.6.23 (2.6.22 is unaffected). This is NOT related to my patch.  It 
crashes even with 1.0.15 version. This is bad :( It crashes immeditely after 
a firmware for the host card is loaded. Can someone confirm that? 
 
> Oh, BTW, it'd be also appreciated if you can write an additional patch
> to add enum definitions for each emu_model type instead of digits.
> "if (emu_model == 3)" is no good style.

OK. I'll do it. 

---
Ctirad